Hotword Private API: Add function and event to query the existence of a speaker model

Hotword Private API: Add function and event to query the existence of a speaker model

BUG=438525
Committed: https://crrev.com/a9d915405c0eade5691c168f897dc7c8a4deba30
Cr-Commit-Position: refs/heads/master@{#321947}

[kcarattini, 2015-03-20 06:53:13]

kcarattini@chromium.org changed reviewers:
+ amistry@chromium.org, benwells@chromium.org, mpearson@chromium.org

[kcarattini, 2015-03-20 06:53:14]

mpearson@ please review tools/metrics/histograms/histograms.xml and
extensions/browser/extension_function_histogram_value.h

benwells@ please review chrome/common/extensions/api/hotword_private.idl

[benwells, 2015-03-20 07:01:40]

lgtm with the comments updated.

https://codereview.chromium.org/1027683002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/hotword_private.idl (right):

https://codereview.chromium.org/1027683002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/hotword_private.idl:146: // Gets the audio history
opt-in state.
I think you're comment needs updating...

https://codereview.chromium.org/1027683002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/hotword_private.idl:175: // Fired when there is a
request for whether the speaker model exists.
I'd update this comment to be clearer, like 'fired when the browser wants to
find out if the spearker model exists'.

[kcarattini, 2015-03-20 07:24:00]

https://codereview.chromium.org/1027683002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/hotword_private.idl (right):

https://codereview.chromium.org/1027683002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/hotword_private.idl:146: // Gets the audio history
opt-in state.
On 2015/03/20 07:01:39, benwells wrote:
> I think you're comment needs updating...

Done.

https://codereview.chromium.org/1027683002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/hotword_private.idl:175: // Fired when there is a
request for whether the speaker model exists.
On 2015/03/20 07:01:38, benwells wrote:
> I'd update this comment to be clearer, like 'fired when the browser wants to
> find out if the spearker model exists'.

Done.

[Mark P, 2015-03-20 16:52:47]

histograms.xml lgtm

[Anand Mistry (off Chromium), 2015-03-23 03:05:38]

lgtm

[kcarattini, 2015-03-24 04:41:59]

The CQ bit was checked by kcarattini@chromium.org

[kcarattini, 2015-03-24 04:42:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, mpearson@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/1027683002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-24 04:42:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1027683002/40001

[commit-bot: I haz the power, 2015-03-24 04:44:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-24 04:44:34]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[kcarattini, 2015-03-24 04:49:55]

The CQ bit was checked by kcarattini@chromium.org

[kcarattini, 2015-03-24 04:49:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, mpearson@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/1027683002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-24 04:50:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1027683002/60001

[commit-bot: I haz the power, 2015-03-24 06:12:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-24 06:12:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kcarattini, 2015-03-24 06:26:15]

The CQ bit was checked by kcarattini@chromium.org

[kcarattini, 2015-03-24 06:26:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, mpearson@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/1027683002/#ps100001
(title: "Upload remaining test files")

[commit-bot: I haz the power, 2015-03-24 06:26:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1027683002/100001

[commit-bot: I haz the power, 2015-03-24 07:33:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-03-24 07:33:56]

Patchset 6 (id:??) landed as
https://crrev.com/a9d915405c0eade5691c168f897dc7c8a4deba30
Cr-Commit-Position: refs/heads/master@{#321947}