Issue 1027653002: [Effen] add StyleNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1027653002: [Effen] add StyleNode (Closed)

Created:
5 years, 9 months ago by rafaelw

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

[Effen] add StyleNode This patch adds a new (non-Render) StyleNode which takes two arguments: A (content) node, which it wraps and a Style object. This allows for styles to be applied to Nodes which are constructed elsewhere (e.g. passed in as arguments). R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/15ee4a3e065e6ea8b4bd643cdf51ca98489fdd84

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -34 lines)			Patch
M	sky/examples/stocks-fn/lib/stock_app.dart	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
M	sky/framework/components/fixed_height_scrollable.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/framework/fn.dart	View	1 2 3	14 chunks	+62 lines, -29 lines	0 comments	Download

Total messages: 4 (1 generated)

rafaelw

5 years, 9 months ago (2015-03-20 14:58:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
15ee4a3e065e6ea8b4bd643cdf51ca98489fdd84 (presubmit successful).