Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1027643002: Add About metric to actions.xml (Closed)

Created:
5 years, 9 months ago by michaelpg
Modified:
5 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add About metric to actions.xml R=isherman@chromium.org Committed: https://crrev.com/1f433a714b436ee5df0e6ba64fa7af66e1a466c3 Cr-Commit-Position: refs/heads/master@{#321628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/metrics/actions/actions.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
michaelpg
Options_About metric was missing from actions.xml (used in c/b/r/options/browser_options.js). One day I'll write a script ...
5 years, 9 months ago (2015-03-20 06:15:01 UTC) #2
Ilya Sherman
LGTM, thanks. On 2015/03/20 06:15:01, michaelpg wrote: > Options_About metric was missing from actions.xml (used ...
5 years, 9 months ago (2015-03-20 19:52:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027643002/1
5 years, 9 months ago (2015-03-20 20:00:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 20:55:25 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1f433a714b436ee5df0e6ba64fa7af66e1a466c3 Cr-Commit-Position: refs/heads/master@{#321628}
5 years, 9 months ago (2015-03-20 20:56:07 UTC) #7
michaelpg
5 years, 9 months ago (2015-03-20 21:32:33 UTC) #8
Message was sent while issue was closed.
On 2015/03/20 19:52:16, Ilya Sherman wrote:
> LGTM, thanks.
> 
> On 2015/03/20 06:15:01, michaelpg wrote:
> > Options_About metric was missing from actions.xml (used in
> > c/b/r/options/browser_options.js).
> > 
> > One day I'll write a script to find all of these...
> 
> That would be lovely!  You might already be aware of it, but there's an
existing
> script that tries to find actions -- extract_actions.py.  Maybe it wouldn't be
> too hard to extend it to find this sort of action as well?

First attempt is at https://codereview.chromium.org/1025673004/

Powered by Google App Engine
This is Rietveld 408576698