Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 102763004: Enable the network connectivity tests. Changes in CL 10299300 would fix (Closed)

Created:
7 years ago by ramant (doing other things)
Modified:
7 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Enable the network connectivity tests. Changes in CL 10299300 would fix the use after free in bug 273917. BUG=273917 R=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/net/network_stats.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
Hi Jim, Missed enabling of NetConnectivity tests while landing CL: https://codereview.chromium.org/102993007/. thanks raman
7 years ago (2013-12-16 20:35:38 UTC) #1
jar (doing other things)
lgtm
7 years ago (2013-12-16 21:47:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/102763004/1
7 years ago (2013-12-16 21:49:07 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-17 04:00:56 UTC) #4
Message was sent while issue was closed.
Change committed as 241147

Powered by Google App Engine
This is Rietveld 408576698