Issue 102763002: Remove TreatNullAs=NullString for HTMLElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 102763002: Remove TreatNullAs=NullString for HTMLElement (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
arv (Not doing code reviews)

CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove TreatNullAs=NullString for HTMLElement http://whatwg.org/html#htmlelement Leave [TreatNullAs=NullString] on innerText/outerText, since they're non-standard properties which need special investigation. Split the tests for Element into a separate block for clarity. The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: Firefox reflects dir as "" and innerText as null. IE throws an exception for dir and reflects innerText as "null". No tested browser throws an exception when setting outerHTML/outerText to null, but ignore that since the behavior wasn't change here. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163116

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -35 lines)			Patch
M	LayoutTests/fast/dom/element-attribute-js-null.html	View	8 chunks	+14 lines, -15 lines	0 comments	Download
M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View	6 chunks	+11 lines, -14 lines	0 comments	Download
M	Source/core/html/HTMLElement.idl	View	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/102763002/1

7 years ago (2013-12-03 20:51:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/102763002/1

7 years ago (2013-12-03 21:06:13 UTC) #4

Message was sent while issue was closed.

Change committed as 163116

Expand Messages | Collapse Messages