Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1027623002: gpu: Measure texture uploads with glTexSubImage2D and glTexImage2D. (Closed)

Created:
5 years, 9 months ago by Daniele Castagna
Modified:
5 years, 9 months ago
Reviewers:
reveman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

glTexImage2D and glTexSubImage2D could have different performance properties. With this patch we benchmark both of these upload techniques. When using glTexSubImage2D the texture storage is specified with glTexStorage2D when available, or glTexImage2D passing an empty pointer as data. Trying to re-land this patch after it broke the perfbots (crbug.com/468748). BUG=468748 Committed: https://crrev.com/e450ffd9dc792387272d5771fdec81639942655d Cr-Commit-Position: refs/heads/master@{#321519}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -31 lines) Patch
M gpu/perftests/texture_upload_perftest.cc View 15 chunks +88 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
reveman
lgtm
5 years, 9 months ago (2015-03-20 04:29:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027623002/20001
5 years, 9 months ago (2015-03-20 04:31:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-20 05:11:18 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 05:12:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e450ffd9dc792387272d5771fdec81639942655d
Cr-Commit-Position: refs/heads/master@{#321519}

Powered by Google App Engine
This is Rietveld 408576698