Source/bindings/templates/dictionary_v8.h - Issue 1027613002: [bindings] Refactor NativeValueTraits<T>::nativeValue to accept isolate as first parameter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/templates/dictionary_v8.h

Issue 1027613002: [bindings] Refactor NativeValueTraits<T>::nativeValue to accept isolate as first parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/bindings/modules/v8/V8BindingForModules.cpp ('k') | Source/bindings/templates/dictionary_v8.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY!	5 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY!

6	6

7 #ifndef {{v8_original_class}}_h	7 #ifndef {{v8_original_class}}_h

8 #define {{v8_original_class}}_h	8 #define {{v8_original_class}}_h

9	9

10 {% for filename in header_includes %}	10 {% for filename in header_includes %}

(...skipping 13 matching lines...) Expand all Loading...
24 void toV8{{cpp_class}}(const {{cpp_class}}&, v8::Local<v8::Object> dictionary, v 8::Local<v8::Object> creationContext, v8::Isolate*);	24 void toV8{{cpp_class}}(const {{cpp_class}}&, v8::Local<v8::Object> dictionary, v 8::Local<v8::Object> creationContext, v8::Isolate*);

25	25

26 template<class CallbackInfo>	26 template<class CallbackInfo>

27 inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}& im pl)	27 inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}& im pl)

28 {	28 {

29 v8SetReturnValue(callbackInfo, toV8(impl, callbackInfo.Holder(), callbackInf o.GetIsolate()));	29 v8SetReturnValue(callbackInfo, toV8(impl, callbackInfo.Holder(), callbackInf o.GetIsolate()));

30 }	30 }

31	31

32 template <>	32 template <>

33 struct NativeValueTraits<{{cpp_class}}> {	33 struct NativeValueTraits<{{cpp_class}}> {

34 static {{cpp_class}} nativeValue(v8::Local<v8::Value>, v8::Isolate*, Excepti onState&);	34 static {{cpp_class}} nativeValue(v8::Isolate*, v8::Local<v8::Value>, Excepti onState&);

35 };	35 };

36	36

37 } // namespace blink	37 } // namespace blink

38	38

39 #endif // {{v8_original_class}}_h	39 #endif // {{v8_original_class}}_h

OLD	NEW