Dart: Removes all but native calls and the handle watcher from the snapshot.

mojo/dart/embedder/dart_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/callback.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/sys_info.h"
 #include "crypto/random.h"
 #include "dart/runtime/include/dart_api.h"
 #include "dart/runtime/include/dart_native_api.h"
 #include "mojo/dart/embedder/builtin.h"
 #include "mojo/dart/embedder/dart_controller.h"
 #include "mojo/dart/embedder/isolate_data.h"
 #include "mojo/public/c/system/core.h"
 
 namespace mojo {
 namespace dart {
 
 extern const uint8_t* snapshot_buffer;
 
 const char* kDartScheme = "dart:";
-const char* kMojoScheme = "mojo:";
 const char* kAsyncLibURL = "dart:async";
 const char* kInternalLibURL = "dart:_internal";
 const char* kIsolateLibURL = "dart:isolate";
 const char* kIOLibURL = "dart:io";
 const char* kCoreLibURL = "dart:core";
 
 static bool IsDartSchemeURL(const char* url_name) {
   static const intptr_t kDartSchemeLen = strlen(kDartScheme);
   // If the URL starts with "dart:" then it is considered as a special
   // library URL which is handled differently from other URLs.
   return (strncmp(url_name, kDartScheme, kDartSchemeLen) == 0);
 }
 
-static bool IsMojoSchemeURL(const char* url_name) {
-  static const intptr_t kMojoSchemeLen = strlen(kMojoScheme);
-  // If the URL starts with "mojo:" then it is considered as a special
-  // library URL which is handled differently from other URLs.
-  return (strncmp(url_name, kMojoScheme, kMojoSchemeLen) == 0);
-}
-
 static bool IsServiceIsolateURL(const char* url_name) {
   if (url_name == nullptr) {
     return false;
   }
   static const intptr_t kServiceIsolateNameLen =
       strlen(DART_VM_SERVICE_ISOLATE_NAME);
   return (strncmp(url_name,
                   DART_VM_SERVICE_ISOLATE_NAME,
                   kServiceIsolateNameLen) == 0);
 }
@@ skipping 65 matching lines @@
         library_url_string);
   }
 
   // Handle URI canonicalization requests.
   const char* url_string = nullptr;
   result = Dart_StringToCString(url, &url_string);
   if (tag == Dart_kCanonicalizeUrl) {
     if (Dart_IsError(result)) {
       return result;
     }
-    const bool is_internal_scheme_url =
-        IsDartSchemeURL(url_string) || IsMojoSchemeURL(url_string);
+    const bool is_internal_scheme_url = IsDartSchemeURL(url_string);
     // If this is a Dart Scheme URL, or a Mojo Scheme URL, then it is not
     // modified as it will be handled internally.
     if (is_internal_scheme_url) {
       return url;
     }
     // Resolve the url within the context of the library's URL.
     Dart_Handle builtin_lib =
         Builtin::GetLibrary(Builtin::kBuiltinLibrary);
     return ResolveUri(library_url, url, builtin_lib);
   }
 
-  if (tag == Dart_kImportTag) {
-    if (IsMojoSchemeURL(url_string)) {
-      Dart_Handle library = Dart_LookupLibrary(url);
-      DART_CHECK_VALID(library);
-      return library;
-    }
-  }
-
   Dart_Handle builtin_lib =
       Builtin::GetLibrary(Builtin::kBuiltinLibrary);
   // Handle 'import' or 'part' requests for all other URIs. Call dart code to
   // read the source code asynchronously.
   return LoadDataAsync_Invoke(
       Dart_NewInteger(tag), url, library_url, builtin_lib, Dart_Null());
 }
 
 static Dart_Handle SetWorkingDirectory(Dart_Handle builtin_lib) {
   base::FilePath current_dir;
@@ skipping 23 matching lines @@
   Dart_Handle core_lib = Dart_LookupLibrary(url);
   DART_CHECK_VALID(internal_lib);
   url = Dart_NewStringFromCString(kAsyncLibURL);
   DART_CHECK_VALID(url);
   Dart_Handle async_lib = Dart_LookupLibrary(url);
   DART_CHECK_VALID(async_lib);
   url = Dart_NewStringFromCString(kIsolateLibURL);
   DART_CHECK_VALID(url);
   Dart_Handle isolate_lib = Dart_LookupLibrary(url);
   DART_CHECK_VALID(isolate_lib);
-  Dart_Handle mojo_core_lib =
-      Builtin::GetLibrary(Builtin::kMojoCoreLibrary);
-  DART_CHECK_VALID(mojo_core_lib);
+  Dart_Handle mojo_internal_lib =
+      Builtin::GetLibrary(Builtin::kMojoInternalLibrary);
+  DART_CHECK_VALID(mojo_internal_lib);
 
   // We need to ensure that all the scripts loaded so far are finalized
   // as we are about to invoke some Dart code below to setup closures.
   Dart_Handle result = Dart_FinalizeLoading(false);
   DART_CHECK_VALID(result);
 
   // Import dart:_internal into dart:mojo.builtin for setting up hooks.
   result = Dart_LibraryImportLibrary(builtin_lib, internal_lib, Dart_Null());
   DART_CHECK_VALID(result);
 
@@ skipping 106 matching lines @@
 
   DPCHECK(!Dart_IsServiceIsolate(isolate));
   Dart_EnterScope();
 
   Dart_IsolateSetStrictCompilation(strict_compilation);
 
   // Setup the native resolvers for the builtin libraries as they are not set
   // up when the snapshot is read.
   CHECK(snapshot_buffer != nullptr);
   Builtin::PrepareLibrary(Builtin::kBuiltinLibrary);
-  Builtin::PrepareLibrary(Builtin::kMojoCoreLibrary);
+  Builtin::PrepareLibrary(Builtin::kMojoInternalLibrary);
 
   if (!callbacks.create.is_null()) {
     callbacks.create.Run(script_uri.c_str(),
                          "main",
                          package_root.c_str(),
                          isolate_data,
                          error);
   }
 
   // Set up the library tag handler for this isolate.
@@ skipping 162 matching lines @@
                                              config.error);
   if (isolate == nullptr) {
     return false;
   }
 
   Dart_EnterIsolate(isolate);
   Dart_Handle result;
   Dart_EnterScope();
 
   // Start the MojoHandleWatcher.
-  Dart_Handle mojo_core_lib =
-      Builtin::GetLibrary(Builtin::kMojoCoreLibrary);
-  DART_CHECK_VALID(mojo_core_lib);
-  Dart_Handle handle_watcher_type = Dart_GetType(
-      mojo_core_lib,
-      Dart_NewStringFromCString("MojoHandleWatcher"),
-      0,
-      nullptr);
+  Dart_Handle mojo_internal_lib =
+      Builtin::GetLibrary(Builtin::kMojoInternalLibrary);
+  DART_CHECK_VALID(mojo_internal_lib);
+  Dart_Handle handle_watcher_type =
+      Dart_GetType(mojo_internal_lib,
+                   Dart_NewStringFromCString("MojoHandleWatcher"), 0, nullptr);
   DART_CHECK_VALID(handle_watcher_type);
   result = Dart_Invoke(
       handle_watcher_type,
       Dart_NewStringFromCString("_start"),
       0,
       nullptr);
   DART_CHECK_VALID(result);
 
   // RunLoop until the handle watcher isolate is spun-up.
   result = Dart_RunLoop();
@@ skipping 83 matching lines @@
     Dart_Cleanup();
     initialized_ = false;
     return false;
   }
 
   Dart_EnterIsolate(root_isolate_);
   Dart_Handle result;
   Dart_EnterScope();
 
   // Start the MojoHandleWatcher.
-  Dart_Handle mojo_core_lib =
-      Builtin::GetLibrary(Builtin::kMojoCoreLibrary);
-  DART_CHECK_VALID(mojo_core_lib);
-  Dart_Handle handle_watcher_type = Dart_GetType(
-      mojo_core_lib,
-      Dart_NewStringFromCString("MojoHandleWatcher"),
-      0,
-      nullptr);
+  Dart_Handle mojo_internal_lib =
+      Builtin::GetLibrary(Builtin::kMojoInternalLibrary);
+  DART_CHECK_VALID(mojo_internal_lib);
+  Dart_Handle handle_watcher_type =
+      Dart_GetType(mojo_internal_lib,
+                   Dart_NewStringFromCString("MojoHandleWatcher"), 0, nullptr);
   DART_CHECK_VALID(handle_watcher_type);
   result = Dart_Invoke(
       handle_watcher_type,
       Dart_NewStringFromCString("_start"),
       0,
       nullptr);
   DART_CHECK_VALID(result);
 
   // RunLoop until the handle watcher isolate is spun-up.
   result = Dart_RunLoop();
@@ skipping 72 matching lines @@
   return true;
 }
 
 void DartController::Shutdown() {
   CHECK(root_isolate_ != nullptr);
   Dart_EnterIsolate(root_isolate_);
   Dart_Handle result;
   Dart_EnterScope();
 
   // Stop the MojoHandleWatcher.
-  Dart_Handle mojo_core_lib =
-      Builtin::GetLibrary(Builtin::kMojoCoreLibrary);
-  DART_CHECK_VALID(mojo_core_lib);
-  Dart_Handle handle_watcher_type = Dart_GetType(
-      mojo_core_lib,
-      Dart_NewStringFromCString("MojoHandleWatcher"),
-      0,
-      nullptr);
+  Dart_Handle mojo_internal_lib =
+      Builtin::GetLibrary(Builtin::kMojoInternalLibrary);
+  DART_CHECK_VALID(mojo_internal_lib);
+  Dart_Handle handle_watcher_type =
+      Dart_GetType(mojo_internal_lib,
+                   Dart_NewStringFromCString("MojoHandleWatcher"), 0, nullptr);
   DART_CHECK_VALID(handle_watcher_type);
   result = Dart_Invoke(
       handle_watcher_type,
       Dart_NewStringFromCString("_stop"),
       0,
       nullptr);
   DART_CHECK_VALID(result);
 
   result = Dart_RunLoop();
   DART_CHECK_VALID(result);
 
   Dart_ExitScope();
   Dart_ShutdownIsolate();
   Dart_Cleanup();
   root_isolate_ = nullptr;
   initialized_ = false;
 }
 
 }  // namespace apps
 }  // namespace mojo