Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1027593005: [es6] remove --harmony-templates flag (Closed)

Created:
5 years, 9 months ago by caitp (gmail)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] remove --harmony-templates flag BUG=v8:3230 R=dslomov@chromium.org, arv@chromium.org LOG=N Committed: https://crrev.com/fd51f615ebaf9a02c125f78a34d3243cc85a0b24 Cr-Commit-Position: refs/heads/master@{#27352}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update draft edition comment for String.raw #

Patch Set 3 : Remove extra references to harmony-templates stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1019 lines) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
D src/harmony-templates.js View 1 chunk +0 lines, -94 lines 0 comments Download
M src/parser.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/preparser.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/scanner.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/scanner.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/string.js View 1 2 chunks +25 lines, -1 line 0 comments Download
A + src/templates.js View 1 chunk +0 lines, -34 lines 0 comments Download
M test/cctest/test-parsing.cc View 7 chunks +5 lines, -17 lines 0 comments Download
M test/js-perf-test/JSTests.json View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/string-raw.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/templates.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/string-raw.js View 1 chunk +0 lines, -258 lines 0 comments Download
D test/mjsunit/harmony/templates.js View 1 chunk +0 lines, -588 lines 0 comments Download
M test/mjsunit/strong/declaration-after-use.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
caitp (gmail)
PTAL --- pretty basic, but the StringRaw implementation is moved to string.js
5 years, 9 months ago (2015-03-20 14:20:23 UTC) #1
arv (Not doing code reviews)
LGTM Please wait for one more reviewer though. https://codereview.chromium.org/1027593005/diff/1/src/string.js File src/string.js (right): https://codereview.chromium.org/1027593005/diff/1/src/string.js#newcode1097 src/string.js:1097: // ...
5 years, 9 months ago (2015-03-20 15:08:53 UTC) #2
Dmitry Lomov (no reviews)
lgtm Make sure that git grep harmony-templates git grep harmony_templates produce now results (I think ...
5 years, 9 months ago (2015-03-20 20:12:11 UTC) #3
Dmitry Lomov (no reviews)
On 2015/03/20 20:12:11, Dmitry Lomov (chromium) wrote: > produce now results (I think a change ...
5 years, 9 months ago (2015-03-20 20:12:39 UTC) #4
Dmitry Lomov (no reviews)
On 2015/03/20 20:12:39, Dmitry Lomov (chromium) wrote: > On 2015/03/20 20:12:11, Dmitry Lomov (chromium) wrote: ...
5 years, 9 months ago (2015-03-20 20:13:00 UTC) #5
caitp (gmail)
On 2015/03/20 20:12:11, Dmitry Lomov (chromium) wrote: > lgtm > > Make sure that > ...
5 years, 9 months ago (2015-03-20 22:34:07 UTC) #6
Dmitry Lomov (no reviews)
On 2015/03/20 22:34:07, caitp wrote: > On 2015/03/20 20:12:11, Dmitry Lomov (chromium) wrote: > > ...
5 years, 9 months ago (2015-03-22 13:28:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027593005/40001
5 years, 9 months ago (2015-03-22 13:46:16 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-23 07:01:42 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 07:02:02 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fd51f615ebaf9a02c125f78a34d3243cc85a0b24
Cr-Commit-Position: refs/heads/master@{#27352}

Powered by Google App Engine
This is Rietveld 408576698