Source/bindings/core/v8/V8DOMConfiguration.cpp - Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8DOMConfiguration.cpp

Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8DOMConfiguration.cpp

diff --git a/Source/bindings/core/v8/V8DOMConfiguration.cpp b/Source/bindings/core/v8/V8DOMConfiguration.cpp

index cc848ad3453a37c849618219117599694d3b6cd1..297448537caf70a1403bdf0c6190ee43977f916a 100644

--- a/Source/bindings/core/v8/V8DOMConfiguration.cpp

+++ b/Source/bindings/core/v8/V8DOMConfiguration.cpp

@@ -128,7 +128,7 @@ void installConstantInternal(v8::Isolate* isolate, v8::Local<v8::FunctionTemplat

value = v8::Number::New(isolate, constant.dvalue);

break;

case V8DOMConfiguration::ConstantTypeString:

- value = v8::String::NewFromUtf8(isolate, constant.svalue);

+ value = v8AtomicString(isolate, constant.svalue);

break;

default:

ASSERT_NOT_REACHED();