Source/modules/fetch/Body.cpp - Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/fetch/Body.cpp

Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/fetch/Body.cpp

diff --git a/Source/modules/fetch/Body.cpp b/Source/modules/fetch/Body.cpp

index 6b43a22094c661901cda9335c75f4c832d802de9..18325ba68eced85beb4689f9a5d1bcfeada5b913 100644

--- a/Source/modules/fetch/Body.cpp

+++ b/Source/modules/fetch/Body.cpp

@@ -424,7 +424,7 @@ void Body::resolveJSON(const String& string)

if (trycatch.HasCaught())

m_resolver->reject(trycatch.Exception());

else

- m_resolver->reject(v8::Exception::Error(v8::String::NewFromUtf8(isolate, "JSON parse error")));

+ m_resolver->reject(v8::Exception::Error(v8NormalString(isolate, "JSON parse error")));

return;

}

m_resolver->resolve(parsed);