Source/bindings/core/v8/V8NPUtils.cpp - Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8NPUtils.cpp

Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8NPUtils.cpp

diff --git a/Source/bindings/core/v8/V8NPUtils.cpp b/Source/bindings/core/v8/V8NPUtils.cpp

index a5df97f5f62feb84011d2868e7169dd69b8e42dc..12f263855c280adbb12fb9bea95feb9cd5b1964a 100644

--- a/Source/bindings/core/v8/V8NPUtils.cpp

+++ b/Source/bindings/core/v8/V8NPUtils.cpp

@@ -94,7 +94,7 @@ v8::Handle<v8::Value> convertNPVariantToV8Object(v8::Isolate* isolate, const NPV

return v8::Undefined(isolate);

case NPVariantType_String: {

NPString src = NPVARIANT_TO_STRING(*variant);

- return v8::String::NewFromUtf8(isolate, src.UTF8Characters, v8::String::kNormalString, src.UTF8Length);

+ return v8NormalString(isolate, src.UTF8Characters, src.UTF8Length);

}

case NPVariantType_Object: {

NPObject* object = NPVARIANT_TO_OBJECT(*variant);