Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: Source/web/tests/CustomEventTest.cpp

Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 return true; 60 return true;
61 } 61 }
62 62
63 virtual void handleEvent(ScriptState* scriptState, Event* event) 63 virtual void handleEvent(ScriptState* scriptState, Event* event)
64 { 64 {
65 EXPECT_EQ(event->type(), "blah"); 65 EXPECT_EQ(event->type(), "blah");
66 66
67 ScriptState::Scope scope(scriptState); 67 ScriptState::Scope scope(scriptState);
68 v8::Handle<v8::Value> jsEvent = toV8(event, scriptState->context()->Glob al(), isolate()); 68 v8::Handle<v8::Value> jsEvent = toV8(event, scriptState->context()->Glob al(), isolate());
69 69
70 EXPECT_EQ(jsEvent->ToObject(isolate())->Get(v8::String::NewFromUtf8(isol ate(), "detail")), v8::Boolean::New(isolate(), true)); 70 EXPECT_EQ(jsEvent->ToObject(isolate())->Get(v8AtomicString(isolate(), "d etail")), v8::Boolean::New(isolate(), true));
71 } 71 }
72 72
73 static PassRefPtr<TestListener> create(ScriptState* scriptState) 73 static PassRefPtr<TestListener> create(ScriptState* scriptState)
74 { 74 {
75 return adoptRef(new TestListener(scriptState)); 75 return adoptRef(new TestListener(scriptState));
76 } 76 }
77 77
78 private: 78 private:
79 TestListener(ScriptState* scriptState) 79 TestListener(ScriptState* scriptState)
80 : V8AbstractEventListener(false, scriptState->world(), scriptState->isol ate()) 80 : V8AbstractEventListener(false, scriptState->world(), scriptState->isol ate())
(...skipping 28 matching lines...) Expand all
109 V8TestingScope scope(isolate); 109 V8TestingScope scope(isolate);
110 customEvent.initCustomEvent("blah", false, false, WebSerializedScriptValue:: serialize(v8::Boolean::New(isolate, true))); 110 customEvent.initCustomEvent("blah", false, false, WebSerializedScriptValue:: serialize(v8::Boolean::New(isolate, true)));
111 RefPtr<EventListener> listener = TestListener::create(scope.scriptState()); 111 RefPtr<EventListener> listener = TestListener::create(scope.scriptState());
112 frame->frame()->document()->addEventListener("blah", listener, false); 112 frame->frame()->document()->addEventListener("blah", listener, false);
113 frame->frame()->document()->dispatchEvent(event); 113 frame->frame()->document()->dispatchEvent(event);
114 114
115 Platform::current()->unitTestSupport()->unregisterAllMockedURLs(); 115 Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
116 } 116 }
117 117
118 } 118 }
OLDNEW
« Source/bindings/core/v8/V8Binding.h ('K') | « Source/web/WebDevToolsFrontendImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698