Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1027593002: Subzero: Support non-IRT immediate calls with -filetype=iasm. (Closed)

Created:
5 years, 9 months ago by Jim Stichnoth
Modified:
5 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Support non-IRT immediate calls with -filetype=iasm. This is done by emitting the following: .byte 0xe8 .long __Sz_AbsoluteZero -4 - . The linker is passed an argument like --defsym=__Sz_AbsoluteZero=0 to force the symbol's value to 0. This special symbol is needed due to an llvm-mc parsing bug. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=927f7ccc6beac42ae894c43cbc75b82919052cb5

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use --defsym= in both places for consistency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M pydir/crosstest.py View 1 chunk +4 lines, -2 lines 0 comments Download
M pydir/szbuild.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/IceFixups.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceFixups.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M src/assembler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
5 years, 9 months ago (2015-03-20 03:19:16 UTC) #2
jvoung (off chromium)
lgtm https://codereview.chromium.org/1027593002/diff/1/pydir/crosstest.py File pydir/crosstest.py (right): https://codereview.chromium.org/1027593002/diff/1/pydir/crosstest.py#newcode150 pydir/crosstest.py:150: '-Wn,-defsym=__Sz_AbsoluteZero=0'] Subzero AbsoluteZero would be -0.0 ? =) ...
5 years, 9 months ago (2015-03-20 06:10:45 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/1027593002/diff/1/pydir/szbuild.py File pydir/szbuild.py (right): https://codereview.chromium.org/1027593002/diff/1/pydir/szbuild.py#newcode300 pydir/szbuild.py:300: '--defsym __Sz_AbsoluteZero=0 ' + On 2015/03/20 06:10:45, jvoung wrote: ...
5 years, 9 months ago (2015-03-20 06:22:53 UTC) #4
Jim Stichnoth
5 years, 9 months ago (2015-03-20 06:23:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
927f7ccc6beac42ae894c43cbc75b82919052cb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698