Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 1027583002: Disable some flaky tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Browser test for basic Chrome OS file manager functionality: 5 // Browser test for basic Chrome OS file manager functionality:
6 // - The file list is updated when a file is added externally to the Downloads 6 // - The file list is updated when a file is added externally to the Downloads
7 // folder. 7 // folder.
8 // - Selecting a file and copy-pasting it with the keyboard copies the file. 8 // - Selecting a file and copy-pasting it with the keyboard copies the file.
9 // - Selecting a file and pressing delete deletes it. 9 // - Selecting a file and pressing delete deletes it.
10 10
(...skipping 1105 matching lines...) Expand 10 before | Expand all | Expand 10 after
1116 TestParameter(NOT_IN_GUEST_MODE, 1116 TestParameter(NOT_IN_GUEST_MODE,
1117 "openFileDialogOnDrive"), 1117 "openFileDialogOnDrive"),
1118 TestParameter(IN_INCOGNITO, 1118 TestParameter(IN_INCOGNITO,
1119 "openFileDialogOnDownloads"), 1119 "openFileDialogOnDownloads"),
1120 TestParameter(IN_INCOGNITO, 1120 TestParameter(IN_INCOGNITO,
1121 "openFileDialogOnDrive"), 1121 "openFileDialogOnDrive"),
1122 TestParameter(NOT_IN_GUEST_MODE, 1122 TestParameter(NOT_IN_GUEST_MODE,
1123 "unloadFileDialog"))); 1123 "unloadFileDialog")));
1124 1124
1125 // Slow tests are disabled on debug build. http://crbug.com/327719 1125 // Slow tests are disabled on debug build. http://crbug.com/327719
1126 #if !defined(NDEBUG) 1126 // Disabled under MSAN as well. http://crbug.com/468980.
1127 #if !defined(NDEBUG) || defined(MEMORY_SANITIZER)
1127 #define MAYBE_CopyBetweenWindows DISABLED_CopyBetweenWindows 1128 #define MAYBE_CopyBetweenWindows DISABLED_CopyBetweenWindows
1128 #else 1129 #else
1129 #define MAYBE_CopyBetweenWindows CopyBetweenWindows 1130 #define MAYBE_CopyBetweenWindows CopyBetweenWindows
1130 #endif 1131 #endif
1131 WRAPPED_INSTANTIATE_TEST_CASE_P( 1132 WRAPPED_INSTANTIATE_TEST_CASE_P(
1132 MAYBE_CopyBetweenWindows, 1133 MAYBE_CopyBetweenWindows,
1133 FileManagerBrowserTest, 1134 FileManagerBrowserTest,
1134 ::testing::Values( 1135 ::testing::Values(
1135 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsLocalToDrive"), 1136 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsLocalToDrive"),
1136 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsLocalToUsb"), 1137 TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsLocalToUsb"),
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
1231 1232
1232 const char* GetTestCaseNameParam() const override { 1233 const char* GetTestCaseNameParam() const override {
1233 return test_case_name_.c_str(); 1234 return test_case_name_.c_str();
1234 } 1235 }
1235 1236
1236 std::string test_case_name_; 1237 std::string test_case_name_;
1237 }; 1238 };
1238 1239
1239 // Slow tests are disabled on debug build. http://crbug.com/327719 1240 // Slow tests are disabled on debug build. http://crbug.com/327719
1240 // Fails on official build. http://crbug.com/429294 1241 // Fails on official build. http://crbug.com/429294
1241 #if !defined(NDEBUG) || defined(OFFICIAL_BUILD) 1242 // Disabled under MSAN as well. http://crbug.com/468982.
1243 #if !defined(NDEBUG) || defined(OFFICIAL_BUILD) || defined(MEMORY_SANITIZER)
1242 #define MAYBE_PRE_BasicDownloads DISABLED_PRE_BasicDownloads 1244 #define MAYBE_PRE_BasicDownloads DISABLED_PRE_BasicDownloads
1243 #define MAYBE_BasicDownloads DISABLED_BasicDownloads 1245 #define MAYBE_BasicDownloads DISABLED_BasicDownloads
1244 #else 1246 #else
1245 #define MAYBE_PRE_BasicDownloads PRE_BasicDownloads 1247 #define MAYBE_PRE_BasicDownloads PRE_BasicDownloads
1246 #define MAYBE_BasicDownloads BasicDownloads 1248 #define MAYBE_BasicDownloads BasicDownloads
1247 #endif 1249 #endif
1248 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, 1250 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest,
1249 MAYBE_PRE_BasicDownloads) { 1251 MAYBE_PRE_BasicDownloads) {
1250 AddAllUsers(); 1252 AddAllUsers();
1251 } 1253 }
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
1470 StartTest(); 1472 StartTest();
1471 } 1473 }
1472 1474
1473 IN_PROC_BROWSER_TEST_F(VideoPlayerBrowserTest, OpenSingleVideoOnDrive) { 1475 IN_PROC_BROWSER_TEST_F(VideoPlayerBrowserTest, OpenSingleVideoOnDrive) {
1474 set_test_case_name("openSingleVideoOnDrive"); 1476 set_test_case_name("openSingleVideoOnDrive");
1475 StartTest(); 1477 StartTest();
1476 } 1478 }
1477 1479
1478 } // namespace 1480 } // namespace
1479 } // namespace file_manager 1481 } // namespace file_manager
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698