Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1027563003: cc: Send updated tile priority with tiles into tracing. (Closed)

Created:
5 years, 9 months ago by vmpstr
Modified:
5 years, 9 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Send updated tile priority with tiles into tracing. This patch adds a combined_priority field to tracing which contains the up-to-date combined priority for the tile. I plan on removing the active/pending priorities from traces, since they typically do not provide any useful information (and are likely to be out of date). R=danakj, enne Committed: https://crrev.com/dcf21da68106fb041650dabf3f65d77927cb4779 Cr-Commit-Position: refs/heads/master@{#321827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -54 lines) Patch
M cc/layers/layer_impl.h View 3 chunks +4 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 3 chunks +5 lines, -2 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 4 chunks +41 lines, -28 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/resources/tile.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/tile.cc View 3 chunks +8 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vmpstr
Please take a look.
5 years, 9 months ago (2015-03-20 00:19:52 UTC) #1
enne (OOO)
lgtm
5 years, 9 months ago (2015-03-23 18:19:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027563003/1
5 years, 9 months ago (2015-03-23 18:19:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 19:16:49 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 19:17:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcf21da68106fb041650dabf3f65d77927cb4779
Cr-Commit-Position: refs/heads/master@{#321827}

Powered by Google App Engine
This is Rietveld 408576698