Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: media/base/video_renderer.h

Issue 1027553002: Change the TimeSource interface to return wallclock time for video. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_renderer.h
diff --git a/media/base/video_renderer.h b/media/base/video_renderer.h
index 7a764b37c5c3b283ccfc43b27392cdbfe4e8338a..c962a29edec163965bf2c048ecd368637bdaa85e 100644
--- a/media/base/video_renderer.h
+++ b/media/base/video_renderer.h
@@ -25,7 +25,7 @@ class MEDIA_EXPORT VideoRenderer {
typedef base::Callback<void(const scoped_refptr<VideoFrame>&)> PaintCB;
// Used to query the current time or duration of the media.
xhwang 2015/03/23 22:20:13 "time or duration" is not accurate now...
DaleCurtis 2015/03/25 00:31:44 Done.
- typedef base::Callback<base::TimeDelta()> TimeDeltaCB;
+ typedef base::Callback<base::TimeTicks(base::TimeDelta)> TimeConverterCB;
xhwang 2015/03/23 22:20:13 nit: s/TimeConverterCB/WallClockTimeCB/ ?
DaleCurtis 2015/03/25 00:31:45 Done.
VideoRenderer();
@@ -52,7 +52,8 @@ class MEDIA_EXPORT VideoRenderer {
//
// |error_cb| is executed if an error was encountered after initialization.
//
- // |get_time_cb| is used to query the current media playback time.
+ // |time_converter_cb| is used to convert media timestamps into wallclock
+ // timestamps.
//
// |waiting_for_decryption_key_cb| is executed whenever the key needed to
// decrypt the stream is not available.
@@ -65,7 +66,7 @@ class MEDIA_EXPORT VideoRenderer {
const PaintCB& paint_cb,
const base::Closure& ended_cb,
const PipelineStatusCB& error_cb,
- const TimeDeltaCB& get_time_cb,
+ const TimeConverterCB& time_converter_cb,
const base::Closure& waiting_for_decryption_key_cb) = 0;
// Discards any video data and stops reading from |stream|, executing

Powered by Google App Engine
This is Rietveld 408576698