Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Unified Diff: media/base/video_renderer.h

Issue 1027553002: Change the TimeSource interface to return wallclock time for video. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove underflow changes. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/time_source.h ('k') | media/base/wall_clock_time_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_renderer.h
diff --git a/media/base/video_renderer.h b/media/base/video_renderer.h
index 7a764b37c5c3b283ccfc43b27392cdbfe4e8338a..360e632517fbf79621781f4d96f330bc0801d505 100644
--- a/media/base/video_renderer.h
+++ b/media/base/video_renderer.h
@@ -24,8 +24,8 @@ class MEDIA_EXPORT VideoRenderer {
// Used to paint VideoFrame.
typedef base::Callback<void(const scoped_refptr<VideoFrame>&)> PaintCB;
- // Used to query the current time or duration of the media.
- typedef base::Callback<base::TimeDelta()> TimeDeltaCB;
+ // Used to convert a media timestamp into a wall clock timestamp.
+ typedef base::Callback<base::TimeTicks(base::TimeDelta)> WallClockTimeCB;
VideoRenderer();
@@ -52,7 +52,8 @@ class MEDIA_EXPORT VideoRenderer {
//
// |error_cb| is executed if an error was encountered after initialization.
//
- // |get_time_cb| is used to query the current media playback time.
+ // |wall_clock_time_cb| is used to convert media timestamps into wallclock
+ // timestamps.
//
// |waiting_for_decryption_key_cb| is executed whenever the key needed to
// decrypt the stream is not available.
@@ -65,7 +66,7 @@ class MEDIA_EXPORT VideoRenderer {
const PaintCB& paint_cb,
const base::Closure& ended_cb,
const PipelineStatusCB& error_cb,
- const TimeDeltaCB& get_time_cb,
+ const WallClockTimeCB& wall_clock_time_cb,
const base::Closure& waiting_for_decryption_key_cb) = 0;
// Discards any video data and stops reading from |stream|, executing
« no previous file with comments | « media/base/time_source.h ('k') | media/base/wall_clock_time_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698