Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: media/base/time_source.h

Issue 1027553002: Change the TimeSource interface to return wallclock time for video. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_TIME_SOURCE_H_ 5 #ifndef MEDIA_BASE_TIME_SOURCE_H_
6 #define MEDIA_BASE_TIME_SOURCE_H_ 6 #define MEDIA_BASE_TIME_SOURCE_H_
7 7
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "media/base/media_export.h" 9 #include "media/base/media_export.h"
10 10
(...skipping 20 matching lines...) Expand all
31 31
32 // Sets the media time to start ticking from. Only valid to call while the 32 // Sets the media time to start ticking from. Only valid to call while the
33 // time source is not ticking. 33 // time source is not ticking.
34 virtual void SetMediaTime(base::TimeDelta time) = 0; 34 virtual void SetMediaTime(base::TimeDelta time) = 0;
35 35
36 // Returns the current media time. 36 // Returns the current media time.
37 // 37 //
38 // Values returned are intended for informational purposes, such as displaying 38 // Values returned are intended for informational purposes, such as displaying
39 // UI with the current minute and second count. While it is guaranteed values 39 // UI with the current minute and second count. While it is guaranteed values
40 // will never go backwards, the frequency at which they update may be low. 40 // will never go backwards, the frequency at which they update may be low.
41 virtual base::TimeDelta CurrentMediaTime() = 0; 41 virtual base::TimeDelta CurrentMediaTime() = 0;
xhwang 2015/03/23 22:20:13 nit: Since TimeDelta specifies a duration, we prob
DaleCurtis 2015/03/25 00:31:44 The current media time is relative to 0?
42 42
43 // Returns the current media time for use with synchronizing video. 43 // Converts a media timestamp into a wallclock timestamp. If media time is
44 // stopped, returns a null TimeTicks.
44 // 45 //
45 // Differences from CurrentMediaTime(): 46 // Values too far ahead of or behind the current media time will return an
46 // - Values returned update at a much higher frequency (e.g., suitable for 47 // estimated value; as such, these values may go backwards in time slightly.
47 // playback of 60 FPS content). 48 virtual base::TimeTicks GetWallclockTimeForMediaTime(
xhwang 2015/03/23 22:20:13 s/Wallclock/WallClock/ At least in WallClockTimeS
xhwang 2015/03/23 22:20:13 nit: how about just GetWallClockTime(base::TimeDel
DaleCurtis 2015/03/25 00:31:44 Done.
48 // - As a result, values may go slightly backwards depending on the 49 base::TimeDelta time) = 0;
49 // implementation (e.g., uses interpolation).
50 //
51 // TODO(scherkus): Replace with a method that returns wall clock time for a
52 // given media time for use with VideoFrameScheduler http://crbug.com/110814
53 virtual base::TimeDelta CurrentMediaTimeForSyncingVideo() = 0;
54 }; 50 };
55 51
56 } // namespace media 52 } // namespace media
57 53
58 #endif // MEDIA_BASE_TIME_SOURCE_H_ 54 #endif // MEDIA_BASE_TIME_SOURCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698