Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1027543003: Turn off incremental linking for full symbols in GN Windows. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn off incremental linking for full symbols in GN Windows. Previously the condition was reversed. We can only do incremental linking when symbols are disabled. I was hoping it would work for minimal symbols but I tested and it still fails. This patch only does incremental linking when symbols are completely disabled. Committed: https://crrev.com/2229d96aae1d38fbdc87455dc10da44ffbfdb1c0 Cr-Commit-Position: refs/heads/master@{#322196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M build/config/win/BUILD.gn View 2 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 9 months ago (2015-03-23 21:15:55 UTC) #2
brettw
Dirk seems to be gone...
5 years, 9 months ago (2015-03-24 21:58:01 UTC) #4
Dirk Pranke
lgtm
5 years, 9 months ago (2015-03-25 01:32:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027543003/1
5 years, 9 months ago (2015-03-25 17:49:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 18:38:19 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 18:39:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2229d96aae1d38fbdc87455dc10da44ffbfdb1c0
Cr-Commit-Position: refs/heads/master@{#322196}

Powered by Google App Engine
This is Rietveld 408576698