Document that tests should avoid using bare SWPs.

Document that tests should avoid using bare SWPs.

Instead, SequencedWorkerPools should be wrapped in a SequencedWorkerPoolOwner to
avoid leak reports.

BUG=273800
R=ajwong@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238451

[earthdok, 2013-12-03 20:01:44]

PTAL

[awong, 2013-12-03 20:33:21]

LGTM


On Tue, Dec 3, 2013 at 12:01 PM, <earthdok@chromium.org> wrote:

> Reviewers: awong,
>
> Message:
> PTAL
>
> Description:
> Document that tests should avoid using bare SWPs.
>
> Instead, SequencedWorkerPools should be wrapped in a
> SequencedWorkerPoolOwner to
> avoid leak reports.
>
> BUG=273800
> R=ajwong@chromium.org
> NOTRY=true
>
> Please review this at https://codereview.chromium.org/102753002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+3, -0 lines):
>   M base/threading/sequenced_worker_pool.h
>
>
> Index: base/threading/sequenced_worker_pool.h
> diff --git a/base/threading/sequenced_worker_pool.h
> b/base/threading/sequenced_worker_pool.h
> index 1bd275b206d4b5b20ecece5da227ad1488beced0..
> d3c85e23ae4690217ab764867738a02d3e1ad1cc 100644
> --- a/base/threading/sequenced_worker_pool.h
> +++ b/base/threading/sequenced_worker_pool.h
> @@ -69,6 +69,9 @@ class SequencedTaskRunner;
>  //
>  // Note that SequencedWorkerPool is RefCountedThreadSafe (inherited
>  // from TaskRunner).
> +//
> +// Test-only code should wrap this in a base::SequencedWorkerPoolOwner to
> avoid
> +// memory leaks. See http://crbug.com/273800
>  class BASE_EXPORT SequencedWorkerPool : public TaskRunner {
>   public:
>    // Defines what should happen to a task posted to the worker pool on
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-12-03 20:41:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/earthdok@chromium.org/102753002/1

[commit-bot: I haz the power, 2013-12-03 20:43:21]

Change committed as 238451