Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1027513004: Fix search box shadowing issue on classic app list. (Closed)

Created:
5 years, 9 months ago by calamity
Modified:
5 years, 9 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@content_view_base_class
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix search box shadowing issue on classic app list. This CL fixes a bug with the classic app list where the search box would turn grey when typing into it. This was happening because the shadow value from the experimental app list was being used. BUG=469983 Committed: https://crrev.com/f046e9d204b7a2fde8e31259ddfb0248771431da Cr-Commit-Position: refs/heads/master@{#321961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/app_list/views/search_result_page_view.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
calamity
5 years, 9 months ago (2015-03-24 07:12:55 UTC) #2
Matt Giuca
lgtm
5 years, 9 months ago (2015-03-24 07:37:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027513004/1
5 years, 9 months ago (2015-03-24 07:37:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 10:02:33 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 10:03:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f046e9d204b7a2fde8e31259ddfb0248771431da
Cr-Commit-Position: refs/heads/master@{#321961}

Powered by Google App Engine
This is Rietveld 408576698