Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: src/heap/mark-compact.h

Issue 1027463002: Revert "Merge old data and pointer space." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HEAP_MARK_COMPACT_H_ 5 #ifndef V8_HEAP_MARK_COMPACT_H_
6 #define V8_HEAP_MARK_COMPACT_H_ 6 #define V8_HEAP_MARK_COMPACT_H_
7 7
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/heap/spaces.h" 9 #include "src/heap/spaces.h"
10 10
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 } 596 }
597 597
598 // TODO(gc) If all evacuation candidates are too popular we 598 // TODO(gc) If all evacuation candidates are too popular we
599 // should stop slots recording entirely. 599 // should stop slots recording entirely.
600 page->ClearEvacuationCandidate(); 600 page->ClearEvacuationCandidate();
601 601
602 // We were not collecting slots on this page that point 602 // We were not collecting slots on this page that point
603 // to other evacuation candidates thus we have to 603 // to other evacuation candidates thus we have to
604 // rescan the page after evacuation to discover and update all 604 // rescan the page after evacuation to discover and update all
605 // pointers to evacuated objects. 605 // pointers to evacuated objects.
606 page->SetFlag(Page::RESCAN_ON_EVACUATION); 606 if (page->owner()->identity() == OLD_DATA_SPACE) {
607 evacuation_candidates_.RemoveElement(page);
608 } else {
609 page->SetFlag(Page::RESCAN_ON_EVACUATION);
610 }
607 } 611 }
608 612
609 void RecordRelocSlot(RelocInfo* rinfo, Object* target); 613 void RecordRelocSlot(RelocInfo* rinfo, Object* target);
610 void RecordCodeEntrySlot(Address slot, Code* target); 614 void RecordCodeEntrySlot(Address slot, Code* target);
611 void RecordCodeTargetPatch(Address pc, Code* target); 615 void RecordCodeTargetPatch(Address pc, Code* target);
612 616
613 INLINE(void RecordSlot( 617 INLINE(void RecordSlot(
614 Object** anchor_slot, Object** slot, Object* object, 618 Object** anchor_slot, Object** slot, Object* object,
615 SlotsBuffer::AdditionMode mode = SlotsBuffer::FAIL_ON_OVERFLOW)); 619 SlotsBuffer::AdditionMode mode = SlotsBuffer::FAIL_ON_OVERFLOW));
616 620
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
896 Heap* heap_; 900 Heap* heap_;
897 base::VirtualMemory* marking_deque_memory_; 901 base::VirtualMemory* marking_deque_memory_;
898 bool marking_deque_memory_committed_; 902 bool marking_deque_memory_committed_;
899 MarkingDeque marking_deque_; 903 MarkingDeque marking_deque_;
900 CodeFlusher* code_flusher_; 904 CodeFlusher* code_flusher_;
901 bool have_code_to_deoptimize_; 905 bool have_code_to_deoptimize_;
902 906
903 List<Page*> evacuation_candidates_; 907 List<Page*> evacuation_candidates_;
904 List<Code*> invalidated_code_; 908 List<Code*> invalidated_code_;
905 909
906 SmartPointer<FreeList> free_list_old_space_; 910 SmartPointer<FreeList> free_list_old_data_space_;
911 SmartPointer<FreeList> free_list_old_pointer_space_;
907 912
908 friend class Heap; 913 friend class Heap;
909 }; 914 };
910 915
911 916
912 class MarkBitCellIterator BASE_EMBEDDED { 917 class MarkBitCellIterator BASE_EMBEDDED {
913 public: 918 public:
914 explicit MarkBitCellIterator(MemoryChunk* chunk) : chunk_(chunk) { 919 explicit MarkBitCellIterator(MemoryChunk* chunk) : chunk_(chunk) {
915 last_cell_index_ = Bitmap::IndexToCell(Bitmap::CellAlignIndex( 920 last_cell_index_ = Bitmap::IndexToCell(Bitmap::CellAlignIndex(
916 chunk_->AddressToMarkbitIndex(chunk_->area_end()))); 921 chunk_->AddressToMarkbitIndex(chunk_->area_end())));
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
962 private: 967 private:
963 MarkCompactCollector* collector_; 968 MarkCompactCollector* collector_;
964 }; 969 };
965 970
966 971
967 const char* AllocationSpaceName(AllocationSpace space); 972 const char* AllocationSpaceName(AllocationSpace space);
968 } 973 }
969 } // namespace v8::internal 974 } // namespace v8::internal
970 975
971 #endif // V8_HEAP_MARK_COMPACT_H_ 976 #endif // V8_HEAP_MARK_COMPACT_H_
OLDNEW
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698