Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1027443002: Merge to XFA: Fix subtle issues in opj_skip_from_memory and add unit tests. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix subtle issues in opj_skip_from_memory and add unit tests. Original Review URL: https://codereview.chromium.org/1016203002 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/db20582cca8f8d540ec463b1694ee9270d27acac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+643 lines, -118 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 4 chunks +112 lines, -87 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 3 chunks +59 lines, -31 lines 0 comments Download
A core/src/fxcodec/codec/fx_codec_jpx_unittest.cpp View 1 chunk +470 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tom Sepez
Committed patchset #1 (id:1) manually as db20582cca8f8d540ec463b1694ee9270d27acac (presubmit successful).
5 years, 9 months ago (2015-03-19 20:02:27 UTC) #1
Lei Zhang
5 years, 9 months ago (2015-03-19 20:47:33 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698