Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1027413002: X87: Remove kind field from StackHandler. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove kind field from StackHandler. port 15f8213809a57c2a163b500a732c9ffe5160a41a (r27263) original commit message: This relands commit 96f79568a926966ebcf0685bf9adc947f4e1fbff. This makes the Isolate::Throw logic not depend on a prediction of whether an exception is caught or uncaught. Such a prediction is inherently undecidable because a finally block can decide between consuming or re-throwing an exception depending on arbitray control flow. There still is a conservative prediction mechanism in place that components like the debugger or tracing can use for reporting. With this change we can get rid of the StackHandler::kind field, a pre-requisite to do table-based lookups of exception handlers. BUG= Committed: https://crrev.com/57037944127d4f3ff4ab8392cb318c651a788925 Cr-Commit-Position: refs/heads/master@{#27385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/x87/macro-assembler-x87.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 9 months ago (2015-03-24 07:20:46 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-24 07:25:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027413002/1
5 years, 9 months ago (2015-03-24 07:25:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 08:08:12 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 08:08:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57037944127d4f3ff4ab8392cb318c651a788925
Cr-Commit-Position: refs/heads/master@{#27385}

Powered by Google App Engine
This is Rietveld 408576698