Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1027403002: Enable hardware acceleration for Nouveau and Stage3D (Closed)

Created:
5 years, 9 months ago by dbdaniel42
Modified:
5 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable hardware acceleration for Nouveau and Stage3D Nouveau has improved a LOT in the 3+ years since it was originally blacklisted. This patch removes the blacklist if the user is running Mesa 10.1 or higher. We can set the version requirement even higher if you think that's best. I've been testing with Mesa 10.5.1 and haven't ran into any crashes or instability. The same thing was done for AMD GPUs running Mesa drivers last year: https://codereview.chromium.org/215493002 This also removes the blacklist for Stage3D on Linux (was blacklisted across all GPUs.) Maybe at one time it was broken but it seems to work just fine now on all the demos I've tried and with massive performance increases from the hardware acceleration. BUG=94103, 129848 Committed: https://crrev.com/4c9c8b2238012338a6395f7101d036e3634ed687 Cr-Commit-Position: refs/heads/master@{#324984}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Update version number #

Patch Set 4 : Update version number again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M gpu/config/software_rendering_list_json.cc View 1 2 3 3 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
dbdaniel42
5 years, 9 months ago (2015-03-24 04:24:52 UTC) #2
Ken Russell (switch to Gerrit)
marcheu, jbauman, zmo: do you have any comments on removing/relaxing these blacklist entries? If we ...
5 years, 9 months ago (2015-03-24 22:18:00 UTC) #4
marcheu
That seems very reasonable to me. We might want to consider blacklisting a bit more, ...
5 years, 9 months ago (2015-03-25 00:51:10 UTC) #5
jbauman
On 2015/03/24 22:18:00, Ken Russell wrote: > marcheu, jbauman, zmo: do you have any comments ...
5 years, 9 months ago (2015-03-25 21:55:00 UTC) #6
Ken Russell (switch to Gerrit)
We're going to give Adobe a heads up on this change before approving it. Please ...
5 years, 9 months ago (2015-03-25 23:13:48 UTC) #7
dbdaniel42
On 2015/03/25 23:13:48, Ken Russell wrote: > We're going to give Adobe a heads up ...
5 years, 8 months ago (2015-03-27 19:05:53 UTC) #8
jbauman
On 2015/03/25 23:13:48, Ken Russell wrote: > We're going to give Adobe a heads up ...
5 years, 8 months ago (2015-04-07 23:06:40 UTC) #9
Ken Russell (switch to Gerrit)
On 2015/04/07 23:06:40, jbauman wrote: > On 2015/03/25 23:13:48, Ken Russell wrote: > > We're ...
5 years, 8 months ago (2015-04-07 23:11:20 UTC) #10
jbauman
lgtm
5 years, 8 months ago (2015-04-07 23:18:54 UTC) #11
dbdaniel42
Did the commit bot get stuck or are we waiting on the other reviewers?
5 years, 8 months ago (2015-04-13 23:27:12 UTC) #12
jbauman
On 2015/04/13 23:27:12, dbdaniel42 wrote: > Did the commit bot get stuck or are we ...
5 years, 8 months ago (2015-04-13 23:29:23 UTC) #13
dbdaniel42
On 2015/04/13 23:29:23, jbauman wrote: > On 2015/04/13 23:27:12, dbdaniel42 wrote: > > Did the ...
5 years, 8 months ago (2015-04-13 23:35:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027403002/60001
5 years, 8 months ago (2015-04-13 23:38:49 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-14 01:55:49 UTC) #18
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 01:56:37 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4c9c8b2238012338a6395f7101d036e3634ed687
Cr-Commit-Position: refs/heads/master@{#324984}

Powered by Google App Engine
This is Rietveld 408576698