Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1027393004: Fix text clipping in CompositorFrameTime Display (Closed)

Created:
5 years, 9 months ago by patro
Modified:
5 years, 8 months ago
Reviewers:
danakj
CC:
ashejole_chromium.org, chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix text clipping in CompositorFrameTime Display Because different OS have different fonts for HUD. Set the width of CompositorFrameTime Display to be maximum of graph width and text width to prevent text clipping. BUG=445877 Committed: https://crrev.com/88b4cf8d33b499f972e1c447e741230170beeb8d Cr-Commit-Position: refs/heads/master@{#322807}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added MeasureText() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M cc/layers/heads_up_display_layer_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 3 chunks +27 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
patro
Kindly Review
5 years, 9 months ago (2015-03-26 05:07:01 UTC) #2
patro
On 2015/03/26 05:07:01, patro wrote: > Kindly Review Text Clipping is occurring on MacOS because ...
5 years, 9 months ago (2015-03-26 17:08:31 UTC) #3
danakj
https://codereview.chromium.org/1027393004/diff/1/cc/layers/heads_up_display_layer_impl.cc File cc/layers/heads_up_display_layer_impl.cc (right): https://codereview.chromium.org/1027393004/diff/1/cc/layers/heads_up_display_layer_impl.cc#newcode616 cc/layers/heads_up_display_layer_impl.cc:616: paint.setTextSize(kFontHeight); Can you add a MeasureText that sits beside ...
5 years, 9 months ago (2015-03-26 22:53:20 UTC) #4
patro
On 2015/03/26 22:53:20, danakj wrote: > https://codereview.chromium.org/1027393004/diff/1/cc/layers/heads_up_display_layer_impl.cc > File cc/layers/heads_up_display_layer_impl.cc (right): > > https://codereview.chromium.org/1027393004/diff/1/cc/layers/heads_up_display_layer_impl.cc#newcode616 > ...
5 years, 9 months ago (2015-03-28 17:42:35 UTC) #5
danakj
LGTM
5 years, 8 months ago (2015-03-30 16:46:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027393004/20001
5 years, 8 months ago (2015-03-30 16:46:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-30 17:48:28 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/88b4cf8d33b499f972e1c447e741230170beeb8d Cr-Commit-Position: refs/heads/master@{#322807}
5 years, 8 months ago (2015-03-30 17:49:30 UTC) #10
jianli
5 years, 8 months ago (2015-03-30 20:40:24 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1047013002/ by jianli@chromium.org.

The reason for reverting is: Speculative revert for Blink layout test failures
in WebKit Mac10.8 (retina):
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28r....

Powered by Google App Engine
This is Rietveld 408576698