src/pdf/SkPDFFont.cpp - Issue 1027373002: Font variations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFFont.cpp

Issue 1027373002: Font variations. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Android and tests. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFFont.cpp

diff --git a/src/pdf/SkPDFFont.cpp b/src/pdf/SkPDFFont.cpp

index 11cf0123378de9fbc944e6767a507ad23074016e..d1f6152553f1c499ee954c38acef4a1d9846019b 100644

--- a/src/pdf/SkPDFFont.cpp

+++ b/src/pdf/SkPDFFont.cpp

@@ -887,9 +887,7 @@ SkPDFFont* SkPDFFont::Create(SkPDFCanon* canon,

SkAdvancedTypefaceMetrics::FontType type =

info ? info->fType : SkAdvancedTypefaceMetrics::kOther_Font;

- if (info &&

- (info->fFlags & SkAdvancedTypefaceMetrics::kMultiMaster_FontFlag)) {

- NOT_IMPLEMENTED(true, true);

+ if (info && (info->fFlags & SkAdvancedTypefaceMetrics::kMultiMaster_FontFlag)) {

return new SkPDFType3Font(info, typeface, glyphID);

}

if (type == SkAdvancedTypefaceMetrics::kType1CID_Font ||