Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1027283005: Files.app: Start to use PiexLoader in image loader. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Start to use PiexLoader in image loader. Note that real PNACL module of PiexLoader has not been submitted. BUG=396702 TEST=manually Committed: https://crrev.com/d62576e5c68576b20cb0f810f76ca7d1a858fa0b Cr-Commit-Position: refs/heads/master@{#321955}

Patch Set 1 #

Patch Set 2 : Replace dummy .js extension with .png extension for avoiding licence check. #

Patch Set 3 : Replace dummy .js extension with .txt extension for avoiding licence check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -51 lines) Patch
M ui/file_manager/file_manager/foreground/js/thumbnail_loader.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/file_manager/image_loader/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/image_loader/image_loader.js View 3 chunks +17 lines, -22 lines 0 comments Download
M ui/file_manager/image_loader/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
A + ui/file_manager/image_loader/piex/piex.nmf.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A ui/file_manager/image_loader/piex/piex.pexe.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/image_loader/piex_loader.js View 1 2 1 chunk +30 lines, -24 lines 0 comments Download
M ui/file_manager/image_loader/request.js View 4 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
hirono
PTAL, thanks!
5 years, 9 months ago (2015-03-24 04:40:26 UTC) #3
fukino
lgtm. Thank you!
5 years, 9 months ago (2015-03-24 05:15:13 UTC) #4
hirono
On 2015/03/24 05:15:13, fukino wrote: > lgtm. Thank you! Thanks!
5 years, 9 months ago (2015-03-24 07:26:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027283005/1
5 years, 9 months ago (2015-03-24 07:26:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51519)
5 years, 9 months ago (2015-03-24 07:32:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027283005/60001
5 years, 9 months ago (2015-03-24 08:03:46 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 9 months ago (2015-03-24 08:29:50 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 08:30:16 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d62576e5c68576b20cb0f810f76ca7d1a858fa0b
Cr-Commit-Position: refs/heads/master@{#321955}

Powered by Google App Engine
This is Rietveld 408576698