Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Unified Diff: src/builtins.cc

Issue 1027283004: [es6] do not add caller/arguments to ES6 function definitions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase + test262 exceptions Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.h ('k') | src/contexts.h » ('j') | src/contexts.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index 2457a956a7a801c59f6885aad59d3ca79b150bca..5b076d13127f5c633b658b7136217eaa0af682c7 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -1000,22 +1000,23 @@ BUILTIN(ArrayConcat) {
// -----------------------------------------------------------------------------
-// Generator and strict mode poison pills
+// Throwers for restricted function properties and strict arguments object
+// properties
-BUILTIN(StrictModePoisonPill) {
+BUILTIN(RestrictedFunctionPropertiesThrower) {
HandleScope scope(isolate);
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate,
- NewTypeError("strict_poison_pill", HandleVector<Object>(NULL, 0)));
+ THROW_NEW_ERROR_RETURN_FAILURE(isolate,
+ NewTypeError("restricted_function_properties",
+ HandleVector<Object>(NULL, 0)));
}
-BUILTIN(GeneratorPoisonPill) {
+BUILTIN(RestrictedStrictArgumentsPropertiesThrower) {
HandleScope scope(isolate);
THROW_NEW_ERROR_RETURN_FAILURE(
isolate,
- NewTypeError("generator_poison_pill", HandleVector<Object>(NULL, 0)));
+ NewTypeError("strict_poison_pill", HandleVector<Object>(NULL, 0)));
arv (Not doing code reviews) 2015/04/07 16:18:39 maybe rename the message key now that we renamed t
caitp (gmail) 2015/04/07 16:29:57 Acknowledged.
}
« no previous file with comments | « src/builtins.h ('k') | src/contexts.h » ('j') | src/contexts.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698