[es6] do not add caller/arguments to ES6 function definitions

test/mjsunit/es6/generators-runtime.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 18 matching lines @@
 
 // See:
 // http://people.mozilla.org/~jorendorff/es6-draft.html#sec-generatorfunction-objects
 
 function f() { }
 function* g() { yield 1; }
 var GeneratorFunctionPrototype = Object.getPrototypeOf(g);
 var GeneratorFunction = GeneratorFunctionPrototype.constructor;
 var GeneratorObjectPrototype = GeneratorFunctionPrototype.prototype;
 
+
+function removePoisoned(a) {
+  return a.filter(function(k) {
+    return k !== "arguments" && k !== "caller";
+  });
+}
+
+
 // A generator function should have the same set of properties as any
 // other function.
 function TestGeneratorFunctionInstance() {
-  var f_own_property_names = Object.getOwnPropertyNames(f);
+  var f_own_property_names = removePoisoned(Object.getOwnPropertyNames(f));

[arv (Not doing code reviews), 2015/03/25 13:36:47]

Would this test be cleaner if f was strict?

[caitp (gmail), 2015/03/25 13:58:09]

a strict ordinary function still has the properties, they just throw --- unless
you mean the name "removePoisoned" is confusing, since they aren't poisoned in
sloppy fns

   var g_own_property_names = Object.getOwnPropertyNames(g);
 
   f_own_property_names.sort();
   g_own_property_names.sort();
 
   assertArrayEquals(f_own_property_names, g_own_property_names);
   var i;
   for (i = 0; i < f_own_property_names.length; i++) {
     var prop = f_own_property_names[i];
     var f_desc = Object.getOwnPropertyDescriptor(f, prop);
     var g_desc = Object.getOwnPropertyDescriptor(g, prop);
     assertEquals(f_desc.configurable, g_desc.configurable, prop);
-    if (prop === 'arguments' || prop === 'caller') {
-      // Unlike sloppy functions, which have read-only data arguments and caller
-      // properties, sloppy generators have a poison pill implemented via
-      // accessors
-      assertFalse('writable' in g_desc, prop);
-      assertTrue(g_desc.get instanceof Function, prop);
-      assertEquals(g_desc.get, g_desc.set, prop);
-    } else {
-      assertEquals(f_desc.writable, g_desc.writable, prop);
-    }
+    assertEquals(f_desc.writable, g_desc.writable, prop);
     assertEquals(f_desc.enumerable, g_desc.enumerable, prop);
   }
 }
 TestGeneratorFunctionInstance();
 
 
 // Generators have an additional object interposed in the chain between
 // themselves and Function.prototype.
 function TestGeneratorFunctionPrototype() {
   // Sanity check.
@@ skipping 62 matching lines @@
   assertTrue((function*(){}).prototype !== (function*(){}).prototype);
   assertTrue((function*(){}).prototype !== g.prototype);
   assertTrue(g.prototype instanceof GeneratorFunctionPrototype);
   assertSame(GeneratorObjectPrototype, Object.getPrototypeOf(g.prototype));
   assertTrue(!(g.prototype instanceof Function));
   assertSame(typeof (g.prototype), "object");
 
   assertArrayEquals([], Object.getOwnPropertyNames(g.prototype));
 }
 TestPerGeneratorPrototype();