Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: test/webkit/fast/js/Object-getOwnPropertyNames.js

Issue 1027283004: [es6] do not add caller/arguments to ES6 function definitions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase + test262 exceptions Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 2 // Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 1. Redistributions of source code must retain the above copyright 7 // 1. Redistributions of source code must retain the above copyright
8 // notice, this list of conditions and the following disclaimer. 8 // notice, this list of conditions and the following disclaimer.
9 // 2. Redistributions in binary form must reproduce the above copyright 9 // 2. Redistributions in binary form must reproduce the above copyright
10 // notice, this list of conditions and the following disclaimer in the 10 // notice, this list of conditions and the following disclaimer in the
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 "(function(){var x=new Date();x.__proto__=[1,2,3];return x;})()": "[]", 53 "(function(){var x=new Date();x.__proto__=[1,2,3];return x;})()": "[]",
54 // RegExp objects 54 // RegExp objects
55 "new RegExp('foo')": "['global', 'ignoreCase', 'lastIndex', 'multiline', 'so urce']", 55 "new RegExp('foo')": "['global', 'ignoreCase', 'lastIndex', 'multiline', 'so urce']",
56 "(function(){var x=new RegExp();x.__proto__=[1,2,3];return x;})()": "['globa l', 'ignoreCase', 'lastIndex', 'multiline', 'source']", 56 "(function(){var x=new RegExp();x.__proto__=[1,2,3];return x;})()": "['globa l', 'ignoreCase', 'lastIndex', 'multiline', 'source']",
57 // Arguments objects 57 // Arguments objects
58 "argumentsObject()": "['callee', 'length']", 58 "argumentsObject()": "['callee', 'length']",
59 "argumentsObject(1)": "['0', 'callee', 'length']", 59 "argumentsObject(1)": "['0', 'callee', 'length']",
60 "argumentsObject(1,2,3)": "['0', '1', '2', 'callee', 'length']", 60 "argumentsObject(1,2,3)": "['0', '1', '2', 'callee', 'length']",
61 "(function(){arguments.__proto__=[1,2,3];return arguments;})()": "['callee', 'length']", 61 "(function(){arguments.__proto__=[1,2,3];return arguments;})()": "['callee', 'length']",
62 // Built-in ECMA functions 62 // Built-in ECMA functions
63 "parseInt": "['arguments', 'caller', 'length', 'name']", 63 "parseInt": "['arguments', 'caller', 'length', 'name']",
arv (Not doing code reviews) 2015/04/07 16:18:40 How come this still has arguments and caller?
caitp (gmail) 2015/04/07 16:29:57 for whatever reason, "parseInt" and "parseFloat" (
arv (Not doing code reviews) 2015/04/07 17:00:12 I think the spec allows this to be implementation
64 "parseFloat": "['arguments', 'caller', 'length', 'name']", 64 "parseFloat": "['arguments', 'caller', 'length', 'name']",
65 "isNaN": "['arguments', 'caller', 'length', 'name']", 65 "isNaN": "['arguments', 'caller', 'length', 'name']",
66 "isFinite": "['arguments', 'caller', 'length', 'name']", 66 "isFinite": "['arguments', 'caller', 'length', 'name']",
67 "escape": "['arguments', 'caller', 'length', 'name']", 67 "escape": "['length', 'name']",
68 "unescape": "['arguments', 'caller', 'length', 'name']", 68 "unescape": "['length', 'name']",
69 "decodeURI": "['arguments', 'caller', 'length', 'name']", 69 "decodeURI": "['length', 'name']",
70 "decodeURIComponent": "['arguments', 'caller', 'length', 'name']", 70 "decodeURIComponent": "['length', 'name']",
71 "encodeURI": "['arguments', 'caller', 'length', 'name']", 71 "encodeURI": "['length', 'name']",
72 "encodeURIComponent": "['arguments', 'caller', 'length', 'name']", 72 "encodeURIComponent": "['length', 'name']",
73 // Built-in ECMA objects 73 // Built-in ECMA objects
74 "Object": "['arguments', 'caller', 'create', 'defineProperties', 'defineProp erty', 'deliverChangeRecords', 'freeze', 'getNotifier', 'getOwnPropertyDescripto r', 'getOwnPropertyNames', 'getOwnPropertySymbols', 'getPrototypeOf', 'is', 'isE xtensible', 'isFrozen', 'isSealed', 'keys', 'length', 'name', 'observe', 'preven tExtensions', 'prototype', 'seal', 'setPrototypeOf', 'unobserve']", 74 "Object": "['arguments', 'caller', 'create', 'defineProperties', 'defineProp erty', 'deliverChangeRecords', 'freeze', 'getNotifier', 'getOwnPropertyDescripto r', 'getOwnPropertyNames', 'getOwnPropertySymbols', 'getPrototypeOf', 'is', 'isE xtensible', 'isFrozen', 'isSealed', 'keys', 'length', 'name', 'observe', 'preven tExtensions', 'prototype', 'seal', 'setPrototypeOf', 'unobserve']",
75 "Object.prototype": "['__defineGetter__', '__defineSetter__', '__lookupGette r__', '__lookupSetter__', '__proto__', 'constructor', 'hasOwnProperty', 'isProto typeOf', 'propertyIsEnumerable', 'toLocaleString', 'toString', 'valueOf']", 75 "Object.prototype": "['__defineGetter__', '__defineSetter__', '__lookupGette r__', '__lookupSetter__', '__proto__', 'constructor', 'hasOwnProperty', 'isProto typeOf', 'propertyIsEnumerable', 'toLocaleString', 'toString', 'valueOf']",
76 "Function": "['arguments', 'caller', 'length', 'name', 'prototype']", 76 "Function": "['arguments', 'caller', 'length', 'name', 'prototype']",
77 "Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller', 'con structor', 'length', 'name', 'toString']", 77 "Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller', 'con structor', 'length', 'name', 'toString']",
78 "Array": "['arguments', 'caller', 'isArray', 'length', 'name', 'observe', 'p rototype', 'unobserve']", 78 "Array": "['arguments', 'caller', 'isArray', 'length', 'name', 'observe', 'p rototype', 'unobserve']",
79 "Array.prototype": "['concat', 'constructor', 'entries', 'every', 'filter', 'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'pu sh', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'spli ce', 'toLocaleString', 'toString', 'unshift']", 79 "Array.prototype": "['concat', 'constructor', 'entries', 'every', 'filter', 'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'pu sh', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'spli ce', 'toLocaleString', 'toString', 'unshift']",
80 "String": "['arguments', 'caller', 'fromCharCode', 'fromCodePoint', 'length' , 'name', 'prototype', 'raw']", 80 "String": "['arguments', 'caller', 'fromCharCode', 'fromCodePoint', 'length' , 'name', 'prototype', 'raw']",
81 "String.prototype": "['anchor', 'big', 'blink', 'bold', 'charAt', 'charCodeA t', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'f ontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'lo caleCompare', 'match', 'normalize', 'repeat', 'replace', 'search', 'slice', 'sma ll', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLo caleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', ' trim', 'trimLeft', 'trimRight', 'valueOf']", 81 "String.prototype": "['anchor', 'big', 'blink', 'bold', 'charAt', 'charCodeA t', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'f ontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'lo caleCompare', 'match', 'normalize', 'repeat', 'replace', 'search', 'slice', 'sma ll', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLo caleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', ' trim', 'trimLeft', 'trimRight', 'valueOf']",
82 "Boolean": "['arguments', 'caller', 'length', 'name', 'prototype']", 82 "Boolean": "['arguments', 'caller', 'length', 'name', 'prototype']",
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 "Number", 126 "Number",
127 "Date", 127 "Date",
128 "RegExp", 128 "RegExp",
129 "Error", 129 "Error",
130 "Math", 130 "Math",
131 "JSON" 131 "JSON"
132 ]; 132 ];
133 133
134 for (var i = 0; i < expectedGlobalPropertyNames.length; ++i) 134 for (var i = 0; i < expectedGlobalPropertyNames.length; ++i)
135 shouldBeTrue("globalPropertyNames.indexOf('" + expectedGlobalPropertyNames[i ] + "') != -1"); 135 shouldBeTrue("globalPropertyNames.indexOf('" + expectedGlobalPropertyNames[i ] + "') != -1");
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698