Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2334)

Unified Diff: chrome/browser/ui/browser_navigator_browsertest_chromeos.cc

Issue 1027273002: Disable Browser_Gets_Created_On_Visiting_Desktop test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
diff --git a/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc b/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
index 695cc5877cb88751d3df2900b7241426bb08c899..ac333ab00dc839591bdad89cf4522fd7cdb197cb 100644
--- a/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
+++ b/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
@@ -66,8 +66,17 @@ IN_PROC_BROWSER_TEST_F(BrowserGuestSessionNavigatorTest,
// Test that in multi user environments a newly created browser gets created
// on the same desktop as the browser is shown on.
+//
+// Flakily hits assert: http://crbug.com/469717
+#if !defined(NDEBUG)
+#define MAYBE_Browser_Gets_Created_On_Visiting_Desktop \
+ DISABLED_Browser_Gets_Created_On_Visiting_Desktop
+#else
+#define MAYBE_Browser_Gets_Created_On_Visiting_Desktop \
+ Browser_Gets_Created_On_Visiting_Desktop
+#endif
IN_PROC_BROWSER_TEST_F(BrowserGuestSessionNavigatorTest,
- Browser_Gets_Created_On_Visiting_Desktop) {
+ MAYBE_Browser_Gets_Created_On_Visiting_Desktop) {
// Test 1: Test that a browser created from a visiting browser will be on the
// same visiting desktop.
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698