Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1027193003: Make MouseWheelEvent::UpdateForRootTransform() not scale the mouse wheel offset (Closed)

Created:
5 years, 9 months ago by pkotwicz
Modified:
5 years, 9 months ago
Reviewers:
girard, pkotwicz1, sadrul
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make MouseWheelEvent::UpdateForRootTransform() not scale the mouse wheel offset The mouse wheel offset is already in "DIPs" because one "mouse wheel click" generates the same offset regardless of the device scale factor. Remove extra scaling done by MouseWheelEvent::UpdateForRootTransform() BUG=412560 TEST=Manual, see bug Committed: https://crrev.com/d450c33f7333878275fc1e94d875691cf08dfeb3 Cr-Commit-Position: refs/heads/master@{#322028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M ui/events/event.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/event.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pkotwicz
girard@ PTAL I think you added MouseWheelEvent::UpdateForRootTransform() in https://chromiumcodereview.appspot.com/16950030/
5 years, 9 months ago (2015-03-24 00:09:41 UTC) #2
girard
On 2015/03/24 00:09:41, pkotwicz wrote: > girard@ PTAL > > I think you added MouseWheelEvent::UpdateForRootTransform() ...
5 years, 9 months ago (2015-03-24 01:41:57 UTC) #3
pkotwicz
Sadrul for OWNERS
5 years, 9 months ago (2015-03-24 14:06:08 UTC) #5
sadrul
lgtm
5 years, 9 months ago (2015-03-24 16:31:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027193003/1
5 years, 9 months ago (2015-03-24 17:05:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 17:44:51 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 17:45:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d450c33f7333878275fc1e94d875691cf08dfeb3
Cr-Commit-Position: refs/heads/master@{#322028}

Powered by Google App Engine
This is Rietveld 408576698