Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1027193002: MIPS64: [turbofan] Support Float64Min and Float64Max. (Closed)

Created:
5 years, 9 months ago by balazs.kilvady
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Support Float[32|64]Min and Float[32|64]Max. MIPS64r6 and MIPS32r6 support for min and max and Float64Max machine operators. BUG= Committed: https://crrev.com/099e06e2406b934453874760451a64a0db799238 Cr-Commit-Position: refs/heads/master@{#28471}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add MIPS32. #

Total comments: 2

Patch Set 4 : Add bodies of 32 bits visitor()'s. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -10 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 3 2 chunks +22 lines, -4 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 2 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
balazs.kilvady
PTAL, Is the arch variant checking is OK and should/could we add min/max to mips32r6 ...
5 years, 9 months ago (2015-03-23 13:37:53 UTC) #2
dusmil.imgtec
Hold on with this, adding instructions in simulator will require simulator refactoring. I have patch ...
5 years, 9 months ago (2015-03-23 13:56:23 UTC) #3
dusmil.imgtec
5 years, 9 months ago (2015-03-23 14:05:51 UTC) #5
balazs.kilvady
5 years, 7 months ago (2015-05-14 12:50:13 UTC) #7
balazs.kilvady
PTAL
5 years, 7 months ago (2015-05-15 10:24:01 UTC) #8
dusmil.imgtec
lgtm.
5 years, 7 months ago (2015-05-15 10:47:11 UTC) #9
paul.l...
https://codereview.chromium.org/1027193002/diff/40001/src/compiler/mips/instruction-selector-mips.cc File src/compiler/mips/instruction-selector-mips.cc (right): https://codereview.chromium.org/1027193002/diff/40001/src/compiler/mips/instruction-selector-mips.cc#newcode1068 src/compiler/mips/instruction-selector-mips.cc:1068: if ((IsMipsArchVariant(kMips32r2) || IsMipsArchVariant(kMips32r6)) && You also need to ...
5 years, 7 months ago (2015-05-15 19:07:48 UTC) #10
balazs.kilvady
https://codereview.chromium.org/1027193002/diff/40001/src/compiler/mips/instruction-selector-mips.cc File src/compiler/mips/instruction-selector-mips.cc (right): https://codereview.chromium.org/1027193002/diff/40001/src/compiler/mips/instruction-selector-mips.cc#newcode1068 src/compiler/mips/instruction-selector-mips.cc:1068: if ((IsMipsArchVariant(kMips32r2) || IsMipsArchVariant(kMips32r6)) && On 2015/05/15 19:07:48, paul.l... ...
5 years, 7 months ago (2015-05-18 12:24:00 UTC) #11
paul.l...
LGTM.
5 years, 7 months ago (2015-05-18 16:48:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027193002/60001
5 years, 7 months ago (2015-05-19 09:49:11 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-19 10:22:18 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 10:22:35 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/099e06e2406b934453874760451a64a0db799238
Cr-Commit-Position: refs/heads/master@{#28471}

Powered by Google App Engine
This is Rietveld 408576698