Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1027183002: [es6] call ToString() on template substitutions (Closed)

Created:
5 years, 9 months ago by caitp (gmail)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] call ToString() on template substitutions BUG=v8:3980 R=arv@chromium.org LOG=N Committed: https://crrev.com/6fcc22dce19d358dcf5fc43710ecc70575190bad Cr-Commit-Position: refs/heads/master@{#27402}

Patch Set 1 #

Patch Set 2 : Simplify generation of binary ops #

Patch Set 3 : Simplify it even more #

Patch Set 4 : Add additional test verifying order of evaluation of substitutions #

Patch Set 5 : Test ToString behaviour for tagged templates + String.raw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -19 lines) Patch
M src/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 1 2 1 chunk +16 lines, -19 lines 0 comments Download
M test/mjsunit/es6/string-raw.js View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
M test/mjsunit/es6/templates.js View 1 2 3 4 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caitp (gmail)
PTAL --- quick fix to ensure template substitutions are ToString()'d as spec'd (https://people.mozilla.org/~jorendorff/es6-draft.html#sec-template-literals-runtime-semantics-evaluation)
5 years, 9 months ago (2015-03-23 12:48:41 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 9 months ago (2015-03-24 11:20:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027183002/80001
5 years, 9 months ago (2015-03-24 12:22:37 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-24 12:43:55 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 12:44:07 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6fcc22dce19d358dcf5fc43710ecc70575190bad
Cr-Commit-Position: refs/heads/master@{#27402}

Powered by Google App Engine
This is Rietveld 408576698