KEYGEN elements should always create LayoutBlockFlow, regardless of display type.

KEYGEN elements should always create LayoutBlockFlow, regardless of display type.

Since it's a replaced element, the display value on a KEYGEN element should
only affect whether it's inline-level or block-level. The actual type of layout
object should be the same, regardless of display type.

BUG=455867
R=jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192399

[Julien - ping for review, 2015-03-23 15:16:51]

lgtm

https://codereview.chromium.org/1027173002/diff/1/Source/core/html/HTMLKeygen...
File Source/core/html/HTMLKeygenElement.cpp (right):

https://codereview.chromium.org/1027173002/diff/1/Source/core/html/HTMLKeygen...
Source/core/html/HTMLKeygenElement.cpp:62: return new LayoutBlockFlow(this);
We have this pattern around the code but it's making us effectively disable
'display' on the element. This confuses webauthors (see e.g.
https://code.google.com/p/chromium/issues/detail?id=335040), however I think
that's fine with a TODO + general bug about this pattern.

[mstensho (USE GERRIT), 2015-03-23 22:46:29]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2015-03-23 22:46:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
jchaffraix@chromium.org
Link to the patchset: https://codereview.chromium.org/1027173002/#ps20001
(title: "code review")

[mstensho (USE GERRIT), 2015-03-23 22:46:46]

https://codereview.chromium.org/1027173002/diff/1/Source/core/html/HTMLKeygen...
File Source/core/html/HTMLKeygenElement.cpp (right):

https://codereview.chromium.org/1027173002/diff/1/Source/core/html/HTMLKeygen...
Source/core/html/HTMLKeygenElement.cpp:62: return new LayoutBlockFlow(this);
On 2015/03/23 15:16:51, Julien Chaffraix - PST wrote:
> We have this pattern around the code but it's making us effectively disable
> 'display' on the element. This confuses webauthors (see e.g.
> https://code.google.com/p/chromium/issues/detail?id=335040), however I think
> that's fine with a TODO + general bug about this pattern.

Done.

[commit-bot: I haz the power, 2015-03-23 22:46:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1027173002/20001

[commit-bot: I haz the power, 2015-03-24 01:41:00]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192399