Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5685)

Unified Diff: chrome/browser/resources/bookmark_manager/js/main.js

Issue 102713002: Support folders in bookmark search (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle single node restoration and only update once per batch delete Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/bookmark_manager/js/main.js
diff --git a/chrome/browser/resources/bookmark_manager/js/main.js b/chrome/browser/resources/bookmark_manager/js/main.js
index d5e157fb5fb0758117cefaa7b93ad98fcba3c23e..10a120684bf9a1235c1d453aeb6601415269e192 100644
--- a/chrome/browser/resources/bookmark_manager/js/main.js
+++ b/chrome/browser/resources/bookmark_manager/js/main.js
@@ -824,6 +824,16 @@ function openItem() {
}
/**
+ * Refreshes search results after delete or undo-delete.
+ * This ensures children of deleted folders do not remain in results
+ */
+function updateSearchResults() {
+ if (list.isSearch()) {
+ list.reload();
+ }
+}
+
+/**
* Deletes the selected bookmarks. The bookmarks are saved in memory in case
* the user needs to undo the deletion.
*/
@@ -843,8 +853,10 @@ function deleteBookmarks() {
lastDeletedNodes.push(results);
// When all nodes have been saved, perform the deletion.
- if (lastDeletedNodes.length === selectedIds.length)
+ if (lastDeletedNodes.length === selectedIds.length) {
performDelete();
+ updateSearchResults();
+ }
});
});
}
@@ -875,6 +887,8 @@ function restoreTree(node, parentId) {
restoreTree(child, result.id);
});
}
+
+ updateSearchResults();
});
}

Powered by Google App Engine
This is Rietveld 408576698