chrome/browser/bookmarks/bookmark_utils.cc - Issue 102713002: Support folders in bookmark search

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_utils.cc

Issue 102713002: Support folders in bookmark search (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test coverage and improve result refresh Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/bookmarks/bookmark_utils.cc

diff --git a/chrome/browser/bookmarks/bookmark_utils.cc b/chrome/browser/bookmarks/bookmark_utils.cc

index 4820b69fbe166bae2d7ccb8a5cac688cd471b35d..f88e288182dabb156049d662a7d606c21dea51a5 100644

--- a/chrome/browser/bookmarks/bookmark_utils.cc

+++ b/chrome/browser/bookmarks/bookmark_utils.cc

@@ -228,7 +228,8 @@ void GetBookmarksContainingText(BookmarkModel* model,

ui::TreeNodeIterator<const BookmarkNode> iterator(model->root_node());

while (iterator.has_next()) {

const BookmarkNode* node = iterator.Next();

- if (DoesBookmarkContainWords(node, words, languages)) {

+ if (DoesBookmarkContainWords(node, words, languages) &&

+ !model->is_permanent_node(node)) {

nodes->push_back(node);

if (nodes->size() == max_count)

return;