Service Worker: Add a timeout for inflight requests.

Service Worker: Add a timeout for inflight requests.

As reasoned on the bug, if an event has not been fulfilled
within 5 minutes, call the callback with ERROR_TIMEOUT
and stop the worker.

BUG=372436
Committed: https://crrev.com/d05209674f5bf7bad0e37fa07247e2dbf9684642
Cr-Commit-Position: refs/heads/master@{#322133}

[falken, 2015-03-25 03:57:24]

falken@chromium.org changed reviewers:
+ kinuko@chromium.org

[falken, 2015-03-25 03:57:25]

PTL

[kinuko, 2015-03-25 04:18:04]

lgtm

https://codereview.chromium.org/1027113002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/1027113002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.cc:320: const int
ServiceWorkerVersion::kRequestTimeoutMinutes = 5;
I assume we can change this value and merge it if this change introduces
undesirable consequence...

https://codereview.chromium.org/1027113002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.cc:800: // message in
DevTools when they occur.
Needs a bug?

https://codereview.chromium.org/1027113002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version_unittest.cc (right):

https://codereview.chromium.org/1027113002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version_unittest.cc:82: void
NoOp() {
base::DoNothing() ?

[kinuko, 2015-03-25 04:18:39]

On 2015/03/25 04:18:04, kinuko wrote:
> lgtm
...except for the compile failure :)

[falken, 2015-03-25 06:10:01]

Thanks!

https://codereview.chromium.org/1027113002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/1027113002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.cc:320: const int
ServiceWorkerVersion::kRequestTimeoutMinutes = 5;
On 2015/03/25 04:18:03, kinuko wrote:
> I assume we can change this value and merge it if this change introduces
> undesirable consequence...

Yes that's reasonable. Or just skip pushing onto |requests_| completely in
AddRequest.

https://codereview.chromium.org/1027113002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.cc:800: // message in
DevTools when they occur.
On 2015/03/25 04:18:03, kinuko wrote:
> Needs a bug?

Done.

https://codereview.chromium.org/1027113002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version_unittest.cc (right):

https://codereview.chromium.org/1027113002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version_unittest.cc:82: void
NoOp() {
On 2015/03/25 04:18:04, kinuko wrote:
> base::DoNothing() ?

Yep, I was looking for that.

[falken, 2015-03-25 06:54:54]

On 2015/03/25 04:18:39, kinuko wrote:
> On 2015/03/25 04:18:04, kinuko wrote:
> > lgtm
> ...except for the compile failure :)

Fixed now. std::queue::swap doesn't exist pre-C11 but it compiled locally for
me.

[falken, 2015-03-25 06:55:24]

The CQ bit was checked by falken@chromium.org

[falken, 2015-03-25 06:55:25]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/1027113002/#ps60001
(title: "dont use std::queue::swap")

[commit-bot: I haz the power, 2015-03-25 06:55:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1027113002/60001

[commit-bot: I haz the power, 2015-03-25 08:37:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-25 08:38:06]

Patchset 4 (id:??) landed as
https://crrev.com/d05209674f5bf7bad0e37fa07247e2dbf9684642
Cr-Commit-Position: refs/heads/master@{#322133}