Improved user-facing messages

tests/pending_manager_test.py

Index: tests/pending_manager_test.py
diff --git a/tests/pending_manager_test.py b/tests/pending_manager_test.py
index efef86f109eee3ce27deaafa82782c19fbd198f0..96b87efad0445c07a158f0faa9553b060a6bc149 100755
--- a/tests/pending_manager_test.py
+++ b/tests/pending_manager_test.py
@@ -165,19 +165,22 @@ class TestPendingManager(mocks.TestCase):
 
   def testNoVerification(self):
     try:
-      # Need at least one verification.
       self._get_pc([], [])
-      self.fail()
-    except AssertionError:
+    except ValueError:
       pass
+    else:
+      self.fail(msg="A PendingManager must require at least one verifier.")
+
     try:
       # Cannot have the same verifier two times.
       self._get_pc(
           [fake.FakeVerifier(base.SUCCEEDED)],
           [fake.FakeVerifier(base.SUCCEEDED)])
-      self.fail()
     except AssertionError:
       pass
+    else:
+      self.fail(msg="A PendingManager should not accept the same verifier"

[Paweł Hajdan Jr., 2014/01/06 11:23:26]

nit: Add a space between "verifier" and "two".

By the way, do you need to say msg= explicitly when calling self.fail?

[pgervais, 2014/01/06 22:22:58]

No, it's optional. However, should the signature of self.fail change in the
future, it would be better to have used keyword argument names instead of
relying on their position.

I haven't found anything related in the Google python style guide.

+                "two times.")
 
   def _check_1(self, pc, result):
     issue = 31337