Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: async_push.py

Issue 102703004: Improved user-facing messages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: Removed pylint comments Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pending_manager.py » ('j') | pending_manager.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: async_push.py
diff --git a/async_push.py b/async_push.py
index 7571d0cb4c40e16c011730fac12611d77bf1f10a..b2c9adf50b18c69a7da05e1f572ec35505da5080 100644
--- a/async_push.py
+++ b/async_push.py
@@ -59,9 +59,9 @@ class AsyncPushStore(AsyncPushNoop):
class AsyncPush(AsyncPushNoop):
- """Sends HTTP Post in a background worker thread.
+ """Sends HTTP Post asynchronously to the tree status application.
- Thread-safe.
+ This object uses a background worker thread, and is thread-safe.
"""
_TERMINATE = object()
@@ -111,7 +111,7 @@ class AsyncPush(AsyncPushNoop):
done = True
logging.debug('Worker thread exiting')
items.remove(self._TERMINATE)
- url = self.url + '/receiver'
+ url = self.url + '/receiver' # application-specific
Paweł Hajdan Jr. 2014/01/06 11:23:26 nit: It's not obvious what this comment adds. I'd
logging.debug('Sending %d items to %s' % (len(items), url))
try:
data = [('p', json.dumps(item)) for item in items]
« no previous file with comments | « no previous file | pending_manager.py » ('j') | pending_manager.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698