Improved user-facing messages

pending_manager.py

 # coding=utf8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Commit queue manager class.
 
 Security implications:
 
 The following hypothesis are made:
 - Commit queue:
@@ skipping 130 matching lines @@
   DESCRIPTION_UPDATED = (
       'Commit queue rejected this change because the description was changed\n'
       'between the time the change entered the commit queue and the time it\n'
       'was ready to commit. You can safely check the commit box again.')
   TRYING_PATCH = 'CQ is trying da patch. Follow status at\n'
   # Maximum number of commits done in a burst.
   MAX_COMMIT_BURST = 4
   # Delay (secs) between commit bursts.
   COMMIT_BURST_DELAY = 10*60
 
-  def __init__(self, context_obj, pre_patch_verifiers, verifiers):
+  def __init__(self, context_obj, pre_patch_verifiers, verifiers,
+               project_name=''):
     """
     Args:
       pre_patch_verifiers: Verifiers objects that are run before applying the
                            patch.
       verifiers: Verifiers object run after applying the patch.
     """
-    assert len(pre_patch_verifiers) or len(verifiers)
+    if not(len(pre_patch_verifiers) or len(verifiers)):
+      raise ValueError('at least one verifier should be defined (in project %s)'
+                       % project_name)
+
     self.context = context_obj
     self.pre_patch_verifiers = pre_patch_verifiers or []
     self.verifiers = verifiers or []
     self.all_verifiers = pre_patch_verifiers + verifiers
     self.queue = PendingQueue()
     # Keep the timestamps of the last few commits so that we can control the
     # pace (burstiness) of commits.
     self.recent_commit_timestamps = []
     # Assert names are unique.
     names = [x.name for x in pre_patch_verifiers + verifiers]
@@ skipping 253 matching lines @@
     try:
       try:
         if pending.get_state() != base.IGNORED:
           self.context.rietveld.set_flag(
               pending.issue, pending.patchset, 'commit', False)
       except urllib2.HTTPError as e:
         logging.error(
             'Failed to set the flag to False for %s with message %s' % (
               pending.pending_name(), message))
         traceback.print_stack()
+        logging.error(str(e))
         errors.send_stack(e)
       if message:
         try:
           self.context.rietveld.add_comment(pending.issue, message)
         except urllib2.HTTPError as e:
           logging.error(
               'Failed to add comment for %s with message %s' % (
                 pending.pending_name(), message))
           traceback.print_stack()
           errors.send_stack(e)
@@ skipping 113 matching lines @@
     """Loads the commit queue state from a JSON file."""
     self.queue = model.load_from_json_file(filename)
 
   def save(self, filename):
     """Save the commit queue state in a simple JSON file."""
     model.save_to_json_file(filename, self.queue)
 
   def close(self):
     """Close all the active pending manager items."""
     self.context.status.close()