Issue 1026943002: Add the layout test case of ash/popup_message.

Issue 1026943002: Add the layout test case of ash/popup_message. (Closed)

Created:
5 years, 9 months ago by Jun Mukai

Modified:
5 years, 9 months ago

Reviewers:
oshima

CC:
chromium-reviews, kalyank, sadrul, sky, Mr4D (OOO till 08-26)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add the layout test case of ash/popup_message. BUG=468494 R=oshima@chromium.org TEST=the new test case fails before r321652, but succeeds on ToT. Committed: https://crrev.com/b4838b40d1a3d0a5b889c57e96c00b61ad022d8c Cr-Commit-Position: refs/heads/master@{#322115}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -0 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/popup_message.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	ash/popup_message.cc	View	1	3 chunks	+6 lines, -0 lines	0 comments	Download
A	ash/popup_message_unittest.cc	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download

Total messages: 9 (1 generated)

Jun Mukai

Updated the code to use GetViewByID rather than exposing the structure. PTAL. # I'll move ...

5 years, 9 months ago (2015-03-24 22:48:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026943002/20001

5 years, 9 months ago (2015-03-24 23:33:05 UTC) #7

commit-bot: I haz the power

5 years, 9 months ago (2015-03-25 05:16:09 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/b4838b40d1a3d0a5b889c57e96c00b61ad022d8c
Cr-Commit-Position: refs/heads/master@{#322115}