Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1026903002: Flush stdout before launching sub-processes. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Flush stdout before launching sub-processes. This should make the test logs more readable. Also give failure summary at end of tests, since searching through the log is tedious. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/da06966129f0a8ab918d2e28a3aae00bee237308

Patch Set 1 #

Patch Set 2 : Log failures from other two scripts #

Total comments: 1

Patch Set 3 : No need to change return os status code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M testing/tools/run_corpus_tests.py View 1 2 4 chunks +11 lines, -3 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 2 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Tom Sepez
Lei, for review.
5 years, 9 months ago (2015-03-20 20:58:27 UTC) #1
Lei Zhang
I think you should ask on infra-dev about this. I also don't know about the ...
5 years, 9 months ago (2015-03-20 21:22:33 UTC) #2
Tom Sepez
On 2015/03/20 21:22:33, Lei Zhang wrote: > I think you should ask on infra-dev about ...
5 years, 9 months ago (2015-03-23 17:51:24 UTC) #3
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-23 18:26:55 UTC) #4
Tom Sepez
Lei, see latest patch set.
5 years, 9 months ago (2015-03-23 18:28:05 UTC) #5
Lei Zhang
On 2015/03/23 18:28:05, Tom Sepez wrote: > Lei, see latest patch set. I just looked ...
5 years, 9 months ago (2015-03-23 18:28:45 UTC) #6
Tom Sepez
On 2015/03/23 18:28:45, Lei Zhang wrote: > On 2015/03/23 18:28:05, Tom Sepez wrote: > > ...
5 years, 9 months ago (2015-03-23 18:30:01 UTC) #7
Tom Sepez
5 years, 9 months ago (2015-03-23 18:31:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
da06966129f0a8ab918d2e28a3aae00bee237308 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698