Issue 10269024: Add stubs to frog to keep dartc happy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10269024: Add stubs to frog to keep dartc happy (Closed)

Created:
8 years, 7 months ago by vsm

Modified:
8 years, 7 months ago

Reviewers:
sra, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add stubs to frog to keep dartc happy Looks like dartc is type-checking html_dartium against dom_frog. Committed: https://code.google.com/p/dart/source/detail?r=7199

Patch Set 2 : Use right exception type #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
M	lib/dom/frog/dom_frog.dart	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	lib/dom/templates/dom/frog/frog_dom.darttemplate	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

LGTM with fix. http://codereview.chromium.org/10269024/diff/1/lib/dom/templates/dom/frog/frog_dom.darttemplate File lib/dom/templates/dom/frog/frog_dom.darttemplate (right): http://codereview.chromium.org/10269024/diff/1/lib/dom/templates/dom/frog/frog_dom.darttemplate#newcode36 lib/dom/templates/dom/frog/frog_dom.darttemplate:36: throw "Unimplemented"; throw const NotImplementedException();

8 years, 7 months ago (2012-05-01 17:44:25 UTC) #2

vsm

8 years, 7 months ago (2012-05-01 18:27:23 UTC) #3

Thanks, fixed and landing.

https://chromiumcodereview.appspot.com/10269024/diff/1/lib/dom/templates/dom/...
File lib/dom/templates/dom/frog/frog_dom.darttemplate (right):

https://chromiumcodereview.appspot.com/10269024/diff/1/lib/dom/templates/dom/...
lib/dom/templates/dom/frog/frog_dom.darttemplate:36: throw "Unimplemented";
On 2012/05/01 17:44:25, sra1 wrote:
> throw const NotImplementedException();

Done.

Expand Messages | Collapse Messages

Issue 10269024: Add stubs to frog to keep dartc happy (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use right exception type #

Messages