Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 1026863002: Fix deploy_sdk.py to error out if files are missing (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix deploy_sdk.py to error out if files are missing I also now deploy sky/bin/sky as sky/lib/sky_tool since pub run doesn't really work very well yet. R=abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/0564e6ac5f04b61f8f0dac1e42fd5d8f16874473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M sky/tools/deploy_sdk.py View 4 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
lgtm
5 years, 9 months ago (2015-03-20 18:09:33 UTC) #1
eseidel
5 years, 9 months ago (2015-03-20 18:21:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0564e6ac5f04b61f8f0dac1e42fd5d8f16874473 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698