chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java - Issue 1026853002: Integrate the notification database with the normal code path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java

Issue 1026853002: Integrate the notification database with the normal code path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-ConfirmShow

Patch Set: android part Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java » ('j') | chrome/browser/notifications/notification_ui_manager_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java

index cf903b0e94eebd677bfb234792bb2d548a44ca6f..504dd796e9000386c7a0a96b8f0495153ac33f1e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java

@@ -52,7 +52,7 @@ public class NotificationService extends IntentService {

@Override

public void onHandleIntent(final Intent intent) {

- if (!intent.hasExtra(NotificationConstants.EXTRA_NOTIFICATION_ID)) return;

+ if (!intent.hasExtra(NotificationConstants.EXTRA_PERSISTENT_NOTIFICATION_ID)) return;

johnme 2015/04/08 17:33:32 Shouldn't you also be checking for the origin? If

Peter Beverloo 2015/04/08 18:57:47 Checking for all three now.

ThreadUtils.runOnUiThread(new Runnable() {

@Override