Integrate the notification database with the normal code path.

chrome/browser/notifications/persistent_notification_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_PERSISTENT_NOTIFICATION_DELEGATE_H_
 #define CHROME_BROWSER_NOTIFICATIONS_PERSISTENT_NOTIFICATION_DELEGATE_H_
 
+#include <stdint.h>

[Avi (use Gerrit), 2015/03/31 20:36:21]

Thank you!

 #include <string>
 
 #include "chrome/browser/notifications/notification_delegate.h"
-#include "content/public/common/platform_notification_data.h"
 #include "url/gurl.h"
 
 namespace content {
 class BrowserContext;
 }
 
 // Delegate responsible for listening to the click event on persistent
 // notifications, to forward them to the PlatformNotificationService so that
 // JavaScript events can be fired on the associated Service Worker.
 class PersistentNotificationDelegate : public NotificationDelegate {
  public:
   PersistentNotificationDelegate(
       content::BrowserContext* browser_context,
-      int64 service_worker_registration_id,
-      const GURL& origin,
-      const content::PlatformNotificationData& notification_data);
+      int64_t persistent_notification_id,
+      const GURL& origin);
 
-  int64 service_worker_registration_id() const {
-    return service_worker_registration_id_;
-  }
-
-  const content::PlatformNotificationData& notification_data() const {
-    return notification_data_;
+  int64 persistent_notification_id() const {

[Avi (use Gerrit), 2015/03/31 20:36:21]

int64_t

[johnme, 2015/04/01 17:39:37]

What's the relation between this and id()? Could id() just be
base::Int64ToString(persistent_notification_id_) ? If you can't unify these,
please clearly document their different purposes.

[Peter Beverloo, 2015/04/01 18:32:17]

Done.

[Peter Beverloo, 2015/04/01 18:32:17]

id() is what we tell the NotificationUIManager (on desktop the Message Center),
p_n_id() is the reference for the NotificationDatabase. Theoretically we can
unify them, but I'd rather not touch that area in this patch. Added a comment.

+    return persistent_notification_id_;
   }
 
   // NotificationDelegate implementation.
   void Display() override;
   void Close(bool by_user) override;
   void Click() override;
   std::string id() const override;
 
  protected:
   ~PersistentNotificationDelegate() override;
 
  private:
   content::BrowserContext* browser_context_;
-  int64 service_worker_registration_id_;
+  int64_t persistent_notification_id_;
   GURL origin_;
-  content::PlatformNotificationData notification_data_;
 
   std::string id_;
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_PERSISTENT_NOTIFICATION_DELEGATE_H_