Issue 1026813002: Revert of Allow compaction when incremental marking is on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1026813002: Revert of Allow compaction when incremental marking is on. (Closed)

Created:
5 years, 9 months ago by Igor Sheludko

Modified:
5 years, 9 months ago

Reviewers:
Hannes Payer (out of office), ulan

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Allow compaction when incremental marking is on. (patchset #1 id:1 of https://codereview.chromium.org/1014263002/) Reason for revert: It seems to cause crbug/469146. Original issue's description: > Allow compaction when incremental marking is on. > > BUG=chromium:450824 > LOG=NO > > Committed: https://crrev.com/92f96e4e9a527fcb085b68f81ee14b26acdd4719 > Cr-Commit-Position: refs/heads/master@{#27267} TBR=hpayer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:450824 Committed: https://crrev.com/371ae8c7adf339b10bdeff7719560837ef8648e7 Cr-Commit-Position: refs/heads/master@{#27345}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
	M	src/heap/incremental-marking.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	M	src/heap/incremental-marking.cc	View		5 chunks	+8 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

Igor Sheludko

Created Revert of Allow compaction when incremental marking is on.

5 years, 9 months ago (2015-03-20 16:06:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026813002/1

5 years, 9 months ago (2015-03-20 16:06:55 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-20 16:07:26 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/371ae8c7adf339b10bdeff7719560837ef8648e7
Cr-Commit-Position: refs/heads/master@{#27345}